fix: Use at least minimum PVC size when mountSources used

Fix #1239

This commit fixes an edge case where a devworkspace that has no volume components,
but has a container component with mountSources enabled will request a PVC size of 0
when using the per-workspace storage strategy.

When mountSources are used, the devworkspace requires storage to store the project sources.
However, it is unknown how much storage is actually required for the project sources.
Thus, we treat container components with mountSources enabled as if they were volume components
with an unspecified size.

Signed-off-by: Andrew Obuchowicz <[email protected]>

Author: AObuchow

Diff for: pkg/provision/storage/perWorkspaceStorage.go

@@ -174,6 +174,8 @@ func (p *PerWorkspaceStorageProvisioner) rewriteContainerVolumeMounts(workspaceI
 //
 // 3. If at least one volume in the devworkspace specifies its size, and the computed PVC size is greater
 //     than the default per-workspace PVC size, the computed PVC size will be used.
+//
+// 4. Container components with mountSources enabled in the devworkspace are treated as if they were volumes with an unspecified size.
 func getPVCSize(workspace *common.DevWorkspaceWithConfig, namespacedConfig *nsconfig.NamespacedConfig) (*resource.Quantity, error) {
 	defaultPVCSize := *workspace.Config.Workspace.DefaultStorageSize.PerWorkspace
 
@@ -197,6 +199,15 @@ func getPVCSize(workspace *common.DevWorkspaceWithConfig, namespacedConfig *nsco
 			}
 			requiredPVCSize.Add(volumeSize)
 		}
+		if component.Container != nil {
+			if component.Container.MountSources != nil && *component.Container.MountSources {
+				// Edge case: If the project source code is being mounted to a container component
+				// then an undefined amount of persistent storage is required.
+				// We treat this case as if there was a volume component with no size defined.
+				allVolumeSizesDefined = false
+				continue
+			}
+		}
 	}
 
 	// Use the calculated PVC size if it's greater than default PVC size