Skip to content

Commit 36f25bc

Browse files
committed
fix: Ignore serviceSpec.ClusterIPs when comparing services to prevent endless
routing r<!-- Please provide instructions here how reviewer can test your changes if applicable -->econciliation loop. The field was introduced in Kubernetes 1.20.
1 parent 27e699c commit 36f25bc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

controllers/controller/devworkspacerouting/sync_services.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131

3232
var serviceDiffOpts = cmp.Options{
3333
cmpopts.IgnoreFields(corev1.Service{}, "TypeMeta", "ObjectMeta", "Status"),
34-
cmpopts.IgnoreFields(corev1.ServiceSpec{}, "ClusterIP", "SessionAffinity"),
34+
cmpopts.IgnoreFields(corev1.ServiceSpec{}, "ClusterIP", "ClusterIPs", "SessionAffinity"),
3535
cmpopts.IgnoreFields(corev1.ServicePort{}, "TargetPort"),
3636
cmpopts.SortSlices(func(a, b corev1.ServicePort) bool {
3737
return strings.Compare(a.Name, b.Name) > 0

0 commit comments

Comments
 (0)