Skip to content

Upgrade to go 1.22, unpin envtest and goimports #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AObuchow opened this issue Sep 11, 2024 · 3 comments
Closed

Upgrade to go 1.22, unpin envtest and goimports #1316

AObuchow opened this issue Sep 11, 2024 · 3 comments
Assignees

Comments

@AObuchow
Copy link
Collaborator

We've had to pin envtest and goimports because we're currently using go 1.20 throughout the repo.

Originally, this was because go 1.22 was not available for the stable release of Fedora. Now, go 1.22 is available in Fedora 40 so we should finally upgrade the go version used throughout the repo.

@AObuchow
Copy link
Collaborator Author

AObuchow commented Sep 11, 2024

Update: Unfortunately, it turns out we can't upgrade to go 1.22 yet because though it's available on Fedora (I'm running 1.22.5) it's not available yet for the go-toolset image we use in our Dockerfiles. The latest version of go-toolset goes up to go 1.21.11.

Since goimports v0.25.0 & latest envtest require go >= 1.22.0, for now we could at best only update to go 1.21.11. Both of these tools would have to remain pinned :(

@AObuchow AObuchow moved this to 📋 Backlog (not in current Sprint) in Eclipse Che Team B Backlog Oct 9, 2024
@dkwon17 dkwon17 moved this from 📋 Backlog (not in current Sprint) to 📅 Planned for this Sprint in Eclipse Che Team B Backlog Nov 20, 2024
@AObuchow
Copy link
Collaborator Author

This issue is now unblocked by #1348!

@dkwon17 dkwon17 assigned dkwon17 and unassigned AObuchow Dec 11, 2024
@dkwon17 dkwon17 moved this from 📅 Planned for this Sprint to 🚧 In Progress in Eclipse Che Team B Backlog Jan 8, 2025
@dkwon17 dkwon17 moved this from 🚧 In Progress to ✅ Done in Eclipse Che Team B Backlog Apr 7, 2025
@dkwon17
Copy link
Collaborator

dkwon17 commented Apr 7, 2025

To avoid this issue from happening in the future, I propose to not unpin goimports and envtest. This way, if there are new changes that in goimports and envtest that break our tests, it won't immediately affect us.

Closing since the project now uses go1.22.

@dkwon17 dkwon17 closed this as completed Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants