Skip to content

Support setting annotations on services/endpoints from DevWorkspace #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amisevsk opened this issue Mar 17, 2022 · 2 comments
Closed

Support setting annotations on services/endpoints from DevWorkspace #799

amisevsk opened this issue Mar 17, 2022 · 2 comments
Milestone
v0.19.x

Comments

@amisevsk
Copy link
Collaborator

Description

With PR #797, changes from devfile/api#661 are now available in the DevWorkspace API. PR #797 added support for setting deployment annotations, but currently the .spec.components[].container.annotation.service and .spec.components[].container.endpoints[].annotation fields are ignored.

Additional context

Devfile API PR introducing feature: devfile/api#661
This was referenced Nov 21, 2022
Open
Closed
@AObuchow
Copy link
Collaborator

Can we close this in favour of #1023?

@amisevsk
Copy link
Collaborator Author

Ah woops, didn't do a great job searching for old issues.

@amisevsk amisevsk mentioned this issue Jan 20, 2023
Open
@amisevsk amisevsk added this to the v0.19.x milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.19.x
Development

No branches or pull requests
2 participants
@AObuchow @amisevsk