Fix fmt with go1.19

Author: feloy

pkg/devfile/parser/data/v2/header.go

@@ -19,12 +19,12 @@ import (
 	devfilepkg "github.com/devfile/api/v2/pkg/devfile"
 )
 
-//GetSchemaVersion gets devfile schema version
+// GetSchemaVersion gets devfile schema version
 func (d *DevfileV2) GetSchemaVersion() string {
 	return d.SchemaVersion
 }
 
-//SetSchemaVersion sets devfile schema version
+// SetSchemaVersion sets devfile schema version
 func (d *DevfileV2) SetSchemaVersion(version string) {
 	d.SchemaVersion = version
 }

pkg/devfile/parser/data/v2/projects.go

@@ -108,7 +108,7 @@ func (d *DevfileV2) DeleteProject(name string) error {
 	}
 }
 
-//GetStarterProjects returns the DevfileStarterProject parsed from devfile
+// GetStarterProjects returns the DevfileStarterProject parsed from devfile
 func (d *DevfileV2) GetStarterProjects(options common.DevfileOptions) ([]v1.StarterProject, error) {
 
 	if reflect.DeepEqual(options, common.DevfileOptions{}) {

pkg/devfile/parser/parse.go

@@ -608,7 +608,7 @@ func convertDevWorskapceTemplateToDevObj(dwTemplate v1.DevWorkspaceTemplate) (d
 
 }
 
-//setDefaults sets the default values for nil boolean properties after the merging of devWorkspaceTemplateSpec is complete
+// setDefaults sets the default values for nil boolean properties after the merging of devWorkspaceTemplateSpec is complete
 func setDefaults(d DevfileObj) (err error) {
 
 	var devfileVersion string
@@ -709,21 +709,21 @@ func setDefaults(d DevfileObj) (err error) {
 	return nil
 }
 
-///setIsDefault sets the default value of CommandGroup.IsDefault if nil
+// setIsDefault sets the default value of CommandGroup.IsDefault if nil
 func setIsDefault(cmdGroup *v1.CommandGroup) {
 	val := cmdGroup.GetIsDefault()
 	cmdGroup.IsDefault = &val
 }
 
-//setEndpoints sets the default value of Endpoint.Secure if nil
+// setEndpoints sets the default value of Endpoint.Secure if nil
 func setEndpoints(endpoints []v1.Endpoint) {
 	for i := range endpoints {
 		val := endpoints[i].GetSecure()
 		endpoints[i].Secure = &val
 	}
 }
 
-//parseKubeResourceFromURI iterate through all kubernetes & openshift components, and parse from uri and update the content to inlined field in devfileObj
+// parseKubeResourceFromURI iterate through all kubernetes & openshift components, and parse from uri and update the content to inlined field in devfileObj
 func parseKubeResourceFromURI(devObj DevfileObj) error {
 	getKubeCompOptions := common.DevfileOptions{
 		ComponentOptions: common.ComponentOptions{
@@ -772,7 +772,7 @@ func parseKubeResourceFromURI(devObj DevfileObj) error {
 	return nil
 }
 
-//convertK8sLikeCompUriToInlined read in kubernetes resources definition from uri and converts to kubernetest inlined field
+// convertK8sLikeCompUriToInlined read in kubernetes resources definition from uri and converts to kubernetest inlined field
 func convertK8sLikeCompUriToInlined(component *v1.Component, d devfileCtx.DevfileCtx) error {
 	var uri string
 	if component.Kubernetes != nil {
@@ -799,7 +799,7 @@ func convertK8sLikeCompUriToInlined(component *v1.Component, d devfileCtx.Devfil
 	return nil
 }
 
-//getKubernetesDefinitionFromUri read in kubernetes resources definition from uri and returns the raw content
+// getKubernetesDefinitionFromUri read in kubernetes resources definition from uri and returns the raw content
 func getKubernetesDefinitionFromUri(uri string, d devfileCtx.DevfileCtx) ([]byte, error) {
 	// validate URI
 	err := validation.ValidateURI(uri)

pkg/devfile/parser/sourceAttribute.go

@@ -17,6 +17,7 @@ package parser
 
 import (
 	"fmt"
+
 	v1 "github.com/devfile/api/v2/pkg/apis/workspaces/v1alpha2"
 	"github.com/devfile/api/v2/pkg/attributes"
 	"github.com/devfile/api/v2/pkg/validation"
@@ -29,7 +30,7 @@ const (
 )
 
 // addSourceAttributesForParentOverride adds an attribute 'api.devfile.io/imported-from=<source reference>'
-//  to all elements of template spec content that support attributes.
+// to all elements of template spec content that support attributes.
 func addSourceAttributesForTemplateSpecContent(sourceImportReference v1.ImportReference, template *v1.DevWorkspaceTemplateSpecContent) {
 	for idx, component := range template.Components {
 		if component.Attributes == nil {
@@ -58,7 +59,7 @@ func addSourceAttributesForTemplateSpecContent(sourceImportReference v1.ImportRe
 }
 
 // addSourceAttributesForParentOverride adds an attribute 'api.devfile.io/parent-override-from=<source reference>'
-//  to all elements of parent override that support attributes.
+// to all elements of parent override that support attributes.
 func addSourceAttributesForParentOverride(sourceImportReference v1.ImportReference, parentOverrides *v1.ParentOverrides) {
 	for idx, component := range parentOverrides.Components {
 		if component.Attributes == nil {
@@ -88,7 +89,7 @@ func addSourceAttributesForParentOverride(sourceImportReference v1.ImportReferen
 }
 
 // addSourceAttributesForPluginOverride adds an attribute 'api.devfile.io/plugin-override-from=<source reference>'
-//  to all elements of plugin override that support attributes.
+// to all elements of plugin override that support attributes.
 func addSourceAttributesForPluginOverride(sourceImportReference v1.ImportReference, pluginOverrides *v1.PluginOverrides) {
 	for idx, component := range pluginOverrides.Components {
 		if component.Attributes == nil {

pkg/testingutil/devfile.go

@@ -127,7 +127,7 @@ func GenerateDummyContainerComponent(name string, volMounts []v1.VolumeMount, en
 			}}}
 }
 
-//DockerImageValues struct can be used to set override or main component struct values
+// DockerImageValues struct can be used to set override or main component struct values
 type DockerImageValues struct {
 	//maps to Image.ImageName
 	ImageName string
@@ -139,8 +139,8 @@ type DockerImageValues struct {
 	RootRequired *bool
 }
 
-//GetDockerImageTestComponent returns a docker image component that is used for testing.
-//The parameters allow customization of the content.  If they are set to nil, then the properties will not be set
+// GetDockerImageTestComponent returns a docker image component that is used for testing.
+// The parameters allow customization of the content.  If they are set to nil, then the properties will not be set
 func GetDockerImageTestComponent(div DockerImageValues, autobuild *bool, attr attributes.Attributes) v1.Component {
 	comp := v1.Component{
 		Name: "image",
@@ -175,8 +175,8 @@ func GetDockerImageTestComponent(div DockerImageValues, autobuild *bool, attr at
 	return comp
 }
 
-//GetDockerImageTestComponentParentOverride returns a docker image parent override component that is used for testing.
-//The parameters allow customization of the content.  If they are set to nil, then the properties will not be set
+// GetDockerImageTestComponentParentOverride returns a docker image parent override component that is used for testing.
+// The parameters allow customization of the content.  If they are set to nil, then the properties will not be set
 func GetDockerImageTestComponentParentOverride(div DockerImageValues) v1.ComponentParentOverride {
 	comp := v1.ComponentParentOverride{
 		Name: "image",
@@ -206,8 +206,8 @@ func GetDockerImageTestComponentParentOverride(div DockerImageValues) v1.Compone
 	return comp
 }
 
-//GetDockerImageTestComponentPluginOverride returns a docker image parent override component that is used for testing.
-//The parameters allow customization of the content.  If they are set to nil, then the properties will not be set
+// GetDockerImageTestComponentPluginOverride returns a docker image parent override component that is used for testing.
+// The parameters allow customization of the content.  If they are set to nil, then the properties will not be set
 func GetDockerImageTestComponentPluginOverride(div DockerImageValues) v1.ComponentPluginOverride {
 	comp := v1.ComponentPluginOverride{
 		Name: "image",

pkg/util/util.go

@@ -302,10 +302,10 @@ func GetAbsPath(path string) (string, error) {
 // existList: List to verify that the returned name does not already exist
 // retries: number of retries to try generating a unique name
 // Returns:
-//		1. randomname: is prefix-suffix, where:
-//				prefix: string passed as prefix or fetched current directory of length same as the passed prefixMaxLen
-//				suffix: 4 char random string
-//      2. error: if requested number of retries also failed to generate unique name
+//  1. randomname: is prefix-suffix, where:
+//     prefix: string passed as prefix or fetched current directory of length same as the passed prefixMaxLen
+//     suffix: 4 char random string
+//  2. error: if requested number of retries also failed to generate unique name
 func GetRandomName(prefix string, prefixMaxLen int, existList []string, retries int) (string, error) {
 	prefix = TruncateString(GetDNS1123Name(strings.ToLower(prefix)), prefixMaxLen)
 	name := fmt.Sprintf("%s-%s", prefix, GenerateRandomString(4))
@@ -458,7 +458,7 @@ func checkPathExistsOnFS(path string, fs filesystem.Filesystem) bool {
 // host:port even if port was not specifically specified in the origin url.
 // If port is not specified, standart port corresponding to url schema is provided.
 // example: for url https://example.com function will return "example.com:443"
-//          for url https://example.com:8443 function will return "example:8443"
+// for url https://example.com:8443 function will return "example:8443"
 func GetHostWithPort(inputURL string) (string, error) {
 	u, err := url.Parse(inputURL)
 	if err != nil {

tests/v2/libraryTest/library_test.go

@@ -268,7 +268,7 @@ func Test_v220_Devfile(t *testing.T) {
 
 }
 
-//Create kube client and context and set as ParserArgs for Parent Kubernetes reference test.  Corresponding main devfile is ../devfile/samples/TestParent_KubeCRD.yaml
+// Create kube client and context and set as ParserArgs for Parent Kubernetes reference test.  Corresponding main devfile is ../devfile/samples/TestParent_KubeCRD.yaml
 func setClientAndContextParserArgs() *parser.ParserArgs {
 	isTrue := true
 	name := "testkubeparent1"

tests/v2/utils/library/test_utils.go

@@ -50,7 +50,7 @@ type DevfileValidator struct{}
 
 var parserArgs = parser.ParserArgs{}
 
-//directory where test devfiles are generated and/or copied
+// directory where test devfiles are generated and/or copied
 const destDir = "tmp/library_test/"
 
 // WriteAndValidate implements DevfileValidator interface.
@@ -305,8 +305,8 @@ func CopyDevfileSamples(t *testing.T, testDevfiles []string) {
 	}
 }
 
-//duplicateDevfileSample: Makes a copy of the parent devfile test artifact that is expected to exist in the tmp/library_test directory.
-//This is used in the multi-threaded parent test scenarios
+// duplicateDevfileSample: Makes a copy of the parent devfile test artifact that is expected to exist in the tmp/library_test directory.
+// This is used in the multi-threaded parent test scenarios
 func duplicateDevfileSample(t *testing.T, src string, dst string) {
 	srcPath := destDir + src
 	destPath := destDir + dst
@@ -376,7 +376,7 @@ func RunTest(testContent commonUtils.TestContent, t *testing.T) {
 	}
 }
 
-//RunStaticTest : Runs fixed tests based on pre-existing artifacts
+// RunStaticTest : Runs fixed tests based on pre-existing artifacts
 func RunStaticTest(testContent commonUtils.TestContent, t *testing.T) {
 	commonUtils.LogMessage(fmt.Sprintf("Start test for %s", testContent.FileName))
 	follower := DevfileFollower{}