deepsource sug fix - ommit comparison

Author: vikramdevtron

api/restHandler/UserRestHandler.go

@@ -211,7 +211,7 @@ func (handler UserRestHandlerImpl) GetById(w http.ResponseWriter, r *http.Reques
 		writeJsonResp(w, err, "Failed to get by id", http.StatusInternalServerError)
 		return
 	}
-	actionUserSuperAdmin, err := handler.userService.IsSuperAdmin(int(userId))
+	isActionUserSuperAdmin, err := handler.userService.IsSuperAdmin(int(userId))
 	if err != nil {
 		handler.logger.Errorw("service err, GetById", "err", err, "id", id)
 		writeJsonResp(w, err, "Failed to check is super admin", http.StatusInternalServerError)
@@ -229,7 +229,7 @@ func (handler UserRestHandlerImpl) GetById(w http.ResponseWriter, r *http.Reques
 				}
 			}
 		}
-		if actionUserSuperAdmin == true {
+		if isActionUserSuperAdmin {
 			authPass = true
 		}
 		if authPass == false {

pkg/user/UserService.go

@@ -317,20 +317,20 @@ func (impl UserServiceImpl) UpdateUser(userInfo *bean.UserInfo) (*bean.UserInfo,
 	if err != nil {
 		return nil, err
 	}
-	IsActionPerformingUserSuperAdmin, err := impl.IsSuperAdmin(int(userInfo.UserId))
+	isActionPerformingUserSuperAdmin, err := impl.IsSuperAdmin(int(userInfo.UserId))
 	if err != nil {
 		return nil, err
 	}
 	//if request comes to make user as a super admin, action performing user also be super admin
 	if userInfo.SuperAdmin {
-		if IsActionPerformingUserSuperAdmin == false {
+		if !isUserSuperAdmin {
 			err = &util.ApiError{HttpStatusCode: http.StatusForbidden, UserMessage: "Invalid request, not allow to update super admin type user"}
 			return nil, err
 		}
 	}
 	//if user which going to updated is super admin, action performing user also be super admin
 	if isUserSuperAdmin == true {
-		if IsActionPerformingUserSuperAdmin == false {
+		if !isActionPerformingUserSuperAdmin {
 			err = &util.ApiError{HttpStatusCode: http.StatusForbidden, UserMessage: "Invalid request, not allow to update super admin type user"}
 			return nil, err
 		}