Skip to content

Commit e3bb553

Browse files
authored
Merge branch 'main' into fix-pr-validator-for-fork-prs
2 parents 67e219f + d37649f commit e3bb553

File tree

1 file changed

+0
-25
lines changed

1 file changed

+0
-25
lines changed

pkg/module/ModuleService.go

-25
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,6 @@ func (impl ModuleServiceImpl) handleModuleNotFoundStatus(moduleName string) (Mod
192192
}
193193
moduleMetaDataStr := string(moduleMetaData)
194194
isLegacyModule := gjson.Get(moduleMetaDataStr, "result.isIncludedInLegacyFullPackage").Bool()
195-
baseMinVersionSupported := gjson.Get(moduleMetaDataStr, "result.baseMinVersionSupported").String()
196195
moduleType := gjson.Get(moduleMetaDataStr, "result.moduleType").String()
197196

198197
flagForEnablingState := false
@@ -260,30 +259,6 @@ func (impl ModuleServiceImpl) handleModuleNotFoundStatus(moduleName string) (Mod
260259
}
261260
}
262261

263-
// if module not enabled in helm for non enterprise-user
264-
if isLegacyModule && moduleName != ModuleNameCicd {
265-
for _, firstReleaseModuleName := range SupportedModuleNamesListFirstReleaseExcludingCicd {
266-
if moduleName != firstReleaseModuleName {
267-
cicdModule, err := impl.moduleRepository.FindOne(ModuleNameCicd)
268-
if err != nil {
269-
if err == pg.ErrNoRows {
270-
return ModuleStatusNotInstalled, moduleType, false, nil
271-
} else {
272-
impl.logger.Errorw("Error in getting cicd module from DB", "err", err)
273-
return ModuleStatusNotInstalled, moduleType, false, err
274-
}
275-
}
276-
cicdVersion := cicdModule.Version
277-
// if cicd was installed and any module/integration comes after that then mark that module installed only if cicd was installed before that module introduction
278-
if len(baseMinVersionSupported) > 0 && cicdVersion < baseMinVersionSupported {
279-
status, err := impl.saveModuleAsInstalled(moduleName, moduleType, flagForEnablingState)
280-
return status, moduleType, false, err
281-
}
282-
break
283-
}
284-
}
285-
}
286-
287262
return ModuleStatusNotInstalled, moduleType, false, nil
288263

289264
}

0 commit comments

Comments
 (0)