Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: hard coded restartPolicy in CronJob #6437

Open
TGTGamer opened this issue Mar 6, 2025 · 3 comments · May be fixed by #6425
Open

Bug: hard coded restartPolicy in CronJob #6437

TGTGamer opened this issue Mar 6, 2025 · 3 comments · May be fixed by #6425
Labels
priority/medium Indiacates that are significant but not urgent. triage-accepted Issue is accepted by the organisation to be worked on.

Comments

@TGTGamer
Copy link

TGTGamer commented Mar 6, 2025

Hi guys,

Looks like you've accidently hard coded the restartPolicy meaning we can't change it. Could you update the cron-job chart please?

devtron/scripts/devtron-reference-helm-charts/cronjob-chart_1-5-0/templates/_pod_template_spec.yaml

Line 80 in c122f9f

restartPolicy: OnFailure

@satyampsoni
Copy link
Contributor

Nice observation, we'll think of working on it in upcoming releases.

@satyampsoni satyampsoni added the priority/medium Indiacates that are significant but not urgent. label Mar 11, 2025
@yuvii yuvii linked a pull request Mar 11, 2025 that will close this issue
Open
@satyampsoni satyampsoni added the triage-accepted Issue is accepted by the organisation to be worked on. label Mar 24, 2025
@satyampsoni
Copy link
Contributor

We are planning on the deprecation of this, keeping this on hold for now.

@TGTGamer
Copy link
Author

We are planning on the deprecation of this, keeping this on hold for now.

To clarify, deprecation of what exactly? The CronJob schema or the specific value within the schema?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/medium Indiacates that are significant but not urgent. triage-accepted Issue is accepted by the organisation to be worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CronJob chart new version - adds support for external secret using ClusterSecretStore yuvii/devtron
2 participants
@TGTGamer @satyampsoni