CronJob chart new version - adds support for external secret using ClusterSecretStore #6425
Conversation
…anaged by ClusterSecretStore
yuvii
requested review from
prakarsh-dt,
pawan-mehta-dt,
nishant-d and
vikramdevtron
as code owners
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2763127 | Triggered | Generic High Entropy Secret | 0a00d51 | scripts/devtron-reference-helm-charts/cronjob-chart_1-6-0/secrets-test-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | 0a00d51 | scripts/devtron-reference-helm-charts/cronjob-chart_1-6-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
|
Hi @yuvii, thanks for the PR!Appreciate your contribution. We're currently considering deprecating this, so I'm putting the PR on hold for now. |
|
@satyampsoni what do you mean by deprecating "this"? Are you deprecating the entire CronJob chart and it won't be an option? Or are you merging it into the basic Deployment chart in some way? |
Description
Creates new cronjob chart (1.6) which fixes the CronJob chart to support ClusterSecretStore in external secret template (aligns it with devtron app template configuration).
Edit:
Also fixed #6437 - changed restartPolicy to be a variable and not hard coded (similar to how the app is set up) ,