Skip to content

History Settings - Log Character Leaves cannot be turned off #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eaganlai opened this issue Dec 4, 2022 · 1 comment
Closed

History Settings - Log Character Leaves cannot be turned off #1343

eaganlai opened this issue Dec 4, 2022 · 1 comment
Labels
Bug 🐞 Something isn't working

Comments

@eaganlai
Copy link

eaganlai commented Dec 4, 2022

The Character Leaves are always logged and shown even if the setting is off.

Below are the HistorySetting, Gameplay Screenshot and Timeline.

image
image
image

Below is from History.gd.

# See if we're logging arrivals and exits
	logArrivals = get_parent().settings.get_value('history', 'log_arrivals', true)
	logExits = get_parent().settings.get_value('history', 'log_exits', true)
                                                      //This get_value.() will always fail and return the default "true" argument.
	if logExits or logArrivals:
		eventsToLog.push_back('dialogic_002')

I have no idea how to fix it. I assume the get_value failed to find the 'log_exits' in the settings, but I don't know how to read, or where to read the setting field names.

The arrival counterpart is working perfectly.

@Jowan-Spooner Jowan-Spooner added the Bug 🐞 Something isn't working label Dec 5, 2022
@Jowan-Spooner Jowan-Spooner added this to the Version 1.4.x milestone Dec 5, 2022
@zaknafean
Copy link
Collaborator

Fixed with #1937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Development

No branches or pull requests

3 participants