Problem with timeline_ended signal

[beanjbunny]

The problem

Describe the bug
In the Signals documentation at https://docs.dialogic.pro/classes/class_dialogicgamehandler.html?highlight=signals#signals, there is a timeline_ended signal defined. While this signal does appear to be present in Dialogic, it does not fire nor run code.

To Reproduce
Steps to reproduce the behavior:

1. Connect to the signal with Dialogic.timeline_ended.connect(test)
2. Write a test function such as func test(): print("this should print"
3. Func test is never run when the timeline is ended.

Expected behavior
Func test or func anything I define should run when the timeline ends. It does not.

Screenshots

System (please complete the following information):

• OS: Windows 10
• Godot Version: 4.3 Stable
• Dialogic Version: 2.0 Alpha 17

Solution

Possible fixes

The signal needs to be reworked so that it fires correctly, I'm not sure there's a second way to go about it.

[Jowan-Spooner]

Not sure what exact version of alpha 17 Wip you are using, but this seems to be working fine on the current main branch for me.