You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds support for loading, compiling, linking, and running components which
use the [Async
ABI](https://github.com/WebAssembly/component-model/blob/main/design/mvp/Async.md)
along with the [`stream`, `future`, and
`error-context`](WebAssembly/component-model#405) types.
It also adds support for generating host bindings such that multiple host
functions can be run concurrently with guest tasks -- without monopolizing the
`Store`.
See the [implementation RFC](bytecodealliance/rfcs#38)
for details, as well as [this
repo](https://github.com/dicej/component-async-demo) containing end-to-end smoke
tests.
Signed-off-by: Joel Dice <[email protected]>
fix clippy warnings and bench/fuzzing errors
Signed-off-by: Joel Dice <[email protected]>
revert atomic.wit whitespace change
Signed-off-by: Joel Dice <[email protected]>
fix build when component-model disabled
Signed-off-by: Joel Dice <[email protected]>
bless component-macro expected output
Signed-off-by: Joel Dice <[email protected]>
fix no-std build error
Signed-off-by: Joel Dice <[email protected]>
fix build with --no-default-features --features runtime,component-model
Signed-off-by: Joel Dice <[email protected]>
partly fix no-std build
It's still broken due to the use of `std::collections::HashMap` in
crates/wasmtime/src/runtime/vm/component.rs. I'll address that as part of the
work to avoid exposing global task/future/stream/error-context handles to
guests.
Signed-off-by: Joel Dice <[email protected]>
maintain per-instance tables for futures, streams, and error-contexts
Signed-off-by: Joel Dice <[email protected]>
refactor task/stream/future handle lifting/lowering
This addresses a couple of issues:
- Previously, we were passing task/stream/future/error-context reps directly to
instances while keeping track of which instance had access to which rep. That
worked fine in that there was no way to forge access to inaccessible reps, but
it leaked information about what other instances were doing. Now we maintain
per-instance waitable and error-context tables which map the reps to and from
the handles which the instance sees.
- The `no_std` build was broken due to use of `HashMap` in
`runtime::vm::component`, which is now fixed.
Note that we use one single table per instance for all tasks, streams, and
futures. This is partly necessary because, when async events are delivered to
the guest, it wouldn't have enough context to know which stream or future we're
talking about if each unique stream and future type had its own table. So at
minimum, we need to use the same table for all streams (regardless of payload
type), and likewise for futures. Also, per
WebAssembly/component-model#395 (comment),
the plan is to move towards a shared table for all resource types as well, so
this moves us in that direction.
Signed-off-by: Joel Dice <[email protected]>
fix wave breakage due to new stream/future/error-context types
Signed-off-by: Joel Dice <[email protected]>
switch wasm-tools to v1.220.0-based branch
Signed-off-by: Joel Dice <[email protected]>
check `task.return` type at runtime
We can't statically verify a given call to `task.return` corresponds to the
expected core signature appropriate for the currently running task, so we must
do so at runtime. In order to make that check efficient, we intern the types.
My initial plan was to use `ModuleInternedTypeIndex` and/or `VMSharedTypeIndex`
for interning, but that got hairy with WasmGC considerations, so instead I added
new fields to `ComponentTypes` and `ComponentTypesBuilder`.
Signed-off-by: Joel Dice <[email protected]>
add `TypedFunc::call_concurrent` and refine stream/future APIs
This implements what I proposed in https://github.com/dicej/rfcs/blob/component-async/accepted/component-model-async.md#wasmtime. Specifically, it adds:
- A new `Promise` type, useful for working with concurrent operations that require access to a `Store` to make progress.
- A new `PromisesUnordered` type for `await`ing multiple promises concurrently
-`TypedFunc::call_concurrent` (which returns a `Promise`), allowing multiple host->guest calls to run concurrently on the same instance.
- Updated `{Stream|Future}{Writer|Reader}` APIs which use `Promise`
The upshot is that the embedder can now ergonomically manage arbitrary numbers
of concurrent operations. Previously, this was a lot more difficult to do
without accidentally starving some of the operations due to another one
monopolizing the `Store`.
Finally, this includes various refactorings and fixes for bugs exposed by the
newer, more versatile APIs.
Signed-off-by: Joel Dice <[email protected]>
clean up verbosity in component/func.rs
Signed-off-by: Joel Dice <[email protected]>
snapshot
Signed-off-by: Joel Dice <[email protected]>
implement stream/future read/write cancellation
This required a somewhat viral addition of `Send` and `Sync` bounds for async
host function closure types, unfortunately.
Signed-off-by: Joel Dice <[email protected]>
add `Func::call_concurrent` and `LinkerInstance::func_new_concurrent`
Signed-off-by: Joel Dice <[email protected]>
dynamic API support for streams/futures/error-contexts
Signed-off-by: Joel Dice <[email protected]>
support callback-less (AKA stackful) async lifts
Signed-off-by: Joel Dice <[email protected]>
fix `call_host` regression
Signed-off-by: Joel Dice <[email protected]>
add component model async end-to-end tests
I've ported these over from https://github.com/dicej/component-async-demo
Signed-off-by: Joel Dice <[email protected]>
fix test regressions and clippy warnings
Signed-off-by: Joel Dice <[email protected]>
satisfy clippy
Signed-off-by: Joel Dice <[email protected]>
fix async tests when `component-model-async` enabled
Enabling this feature for all tests revealed various missing pieces in the new
`concurrent.rs` fiber mechanism, which I've addressed.
This adds a bunch of ugly `#[cfg(feature = "component-model-async")]` guards,
but those will all go away once I unify the two async fiber implementations.
Signed-off-by: Joel Dice <[email protected]>
add and modify tests to cover concurrent APIs
Primarily, this tests and implements cases where parameters and/or results must
be passed via linear memory instead of the stack.
Signed-off-by: Joel Dice <[email protected]>
`concurrent_{imports|exports}` component macro codegen tests
This enables codegen testing of the `concurrent_imports` and
`concurrent_exports` options to `wasmtime::component::bindgen` and also fixes
code generation for world-level function and resource exports that use the
concurrent call style.
Signed-off-by: Joel Dice <[email protected]>
`concurrent_{imports|exports}` component macro expanded tests
This enables testing of the `concurrent_imports` and `concurrent_exports`
options in `crates/component-macro/tests/expanded.rs`.
Signed-off-by: Joel Dice <[email protected]>
add tests/misc_testsuite/component-model-async/*.wast
These only test instantiation of components which use various async options and
built-ins so far. Next, I'll happy and sad path tests which actually execute
code.
Signed-off-by: Joel Dice <[email protected]>
appease clippy
Signed-off-by: Joel Dice <[email protected]>
add tests/misc_testsuite/component-model-async/fused.wast
Signed-off-by: Joel Dice <[email protected]>
add non-panicking bounds checks where appropriate
Signed-off-by: Joel Dice <[email protected]>
remove post-return bits from async result lift code
...at least until we've determined whether post-return options even make sense
for async-lifted exports.
Signed-off-by: Joel Dice <[email protected]>
fix component-model-async/fused.wast test failure
Signed-off-by: Joel Dice <[email protected]>
use `enum` types to represent status and event codes
Signed-off-by: Joel Dice <[email protected]>
fix component-model-async/fused.wast test failure (2nd try)
Signed-off-by: Joel Dice <[email protected]>
use `gc_types = true` in component-model-async/fused.wast
We use `Instruction::RefFunc` when generating adapters for async lifts and/or
lowers, which Winch doesn't understand, and apparently `gc_types = true` is what
tells the test infra not to use Winch.
Signed-off-by: Joel Dice <[email protected]>
trap if async function finishes without calling `task.return`
Signed-off-by: Joel Dice <[email protected]>
update wit-bindgen and fix rebase damage
Signed-off-by: Joel Dice <[email protected]>
call post-return function if any for async->sync fused calls
Signed-off-by: Joel Dice <[email protected]>
0 commit comments