Skip to content

Commit df09947

Browse files
Merge branch 'master' into feature/examples_search-filter
# Conflicts: # CHANGELOG.md # packages/forms/examples/forms/forms.module.ts
2 parents cb4b3a6 + e710501 commit df09947

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+2941
-1122
lines changed

CHANGELOG.md

+14-1
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
1515
- `forms/range-slider` Added documentation.
1616
- `forms/timepicker` Added documentation.
1717
- `forms/search-filter` Added documentation.
18+
- `forms/upload` Added documentation.
1819
- `forms/wysiwyg` Added documentation.
1920
- `layout/cookie-consent` Added documentation.
2021
- `layout/hero` Added documentation.
2122
- `layout/pane` Added documentation.
2223
- `selectable-list` Added documentation.
24+
- `utils/filter` Added documentation.
25+
- `utils/labels` Added documentation.
26+
- `utils/window` Added documentation.
27+
28+
### Changed
29+
- `context` The ContextModule is no longer dependent on the ContextStoreModule.
30+
31+
### Fixed
32+
- `upload` Updated the required styling to be in sync with the corresponding Core Branding classes.
33+
- `upload` Removed unnecessary module imports that caused build conflicts.
34+
- `layout/hero` Removed unnecessary module imports that caused build conflicts.
2335

2436
## [1.0.3] - 2018-09-25
2537
### Added
@@ -57,7 +69,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
5769
Initial release.
5870

5971

60-
[Unreleased]: https://github.com/digipolisantwerp/acpaas-ui_angular/compare/v1.0.2...HEAD
72+
[Unreleased]: https://github.com/digipolisantwerp/acpaas-ui_angular/compare/v1.0.3...HEAD
73+
[1.0.3]: https://github.com/digipolisantwerp/acpaas-ui_angular/compare/v1.0.2...v1.0.3
6174
[1.0.2]: https://github.com/digipolisantwerp/acpaas-ui_angular/compare/v1.0.1...v1.0.2
6275
[1.0.1]: https://github.com/digipolisantwerp/acpaas-ui_angular/compare/v1.0.0...v1.0.1
6376
[1.0.0]: https://github.com/digipolisantwerp/acpaas-ui_angular/compare/v1.0.0

CONTRIBUTING.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ Hi! We're really excited that you are interested in contributing to ACPaaS UI. B
1111

1212
## Issue Reporting Guidelines
1313

14-
- Use the [#acpaas-ui channel](https://dgpls.slack.com/messages/C4M60PQJF) on slack to ask questions about using ACPaaS UI.
15-
- Use the [#acpaas-ui-dev channel](https://dgpls.slack.com/messages/C4S2D7KTK) on slack to discuss changes to the ACPaaS UI code itself.
14+
- If you're not yet a member of our DigAnt Café slack community, you can easily [join here](https://digantcafe-slack.digipolis.be).
15+
- Use the [#acpaas-ui channel](https://digantcafe.slack.com/messages/CDDLYJU65/) on slack to ask questions about using ACPaaS UI.
16+
- Use the [#acpaas-ui-ngx channel][acpaas-ui-ngx] on slack to discuss changes to the ACPaaS UI code itself.
1617
- Use [GitHub Issues][github-issues] to report bugs, request features, ask policy questions or propose policy changes.
1718

1819
> Note: policy questions are about the way ACPaaS UI is developed and released, or about its architecture. We use github issues to have a public archive of these discussions.
@@ -89,10 +90,12 @@ $ npm run styleguide
8990

9091
ACPaaS UI is supplied as a single library on NPM [@acpaas-ui/ngx-components](https://www.npmjs.com/package/@acpaas-ui/ngx-components), although related components (e.g. the [smart widgets](https://github.com/digipolisantwerp/smart-widgets)) may be packaged independently.
9192

92-
It is released at least once a month, and more often if there are high priority changes. If your PR has been merged but not yet released, and it is high priority, please ping the [#acpaas-ui-dev channel](https://dgpls.slack.com/messages/C4S2D7KTK) to ask for an out-of-band release. (Before you do so, check the [dev guide](./guidelines/DEV_GUIDE.md#development-snapshots) for ways to use it without an official release.)
93+
It is released at least once a month, and more often if there are high priority changes. If your PR has been merged but not yet released, and it is high priority, please ping the [#acpaas-ui-ngx channel][acpaas-ui-ngx] to ask for an out-of-band release. (Before you do so, check the [dev guide](./guidelines/DEV_GUIDE.md#development-snapshots) for ways to use it without an official release.)
9394

9495
The project follows [Semantic Versioning](https://semver.org/). The latest stable major version is developed on the `master` branch. For other major versions there are separate `vX-dev` branches. For more info on the exact versioning policy, see the [versioning guide](./guidelines/VERSIONING.md).
9596

9697
A [changelog](CHANGELOG.md) is provided for your convenience.
9798

9899
> Maintainers: see the [release guide](./guidelines/RELEASE.md) for guidance on releases and versioning.
100+
101+
[acpaas-ui-ngx]: https://digantcafe.slack.com/messages/CDF95H5B7/

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ This library contains the following components:
7676

7777
## Questions
7878

79-
For questions and support please ask a question on the [#acpaas-ui slack channel][acpaas-ui-slack].
79+
For questions and support please ask a question on the [#acpaas-ui slack channel][acpaas-ui-slack]. If you're not yet a member of our DigAnt Café slack community, you can easily [join here](https://digantcafe-slack.digipolis.be).
8080

8181
If you stumble across a bug or missing feature, feel free to [report an issue][acpaas-ui-angular-issues]. Please fill out the issue template completely when [opening an issue][acpaas-ui-angular-issues]. This will help us get to your issue sooner.
8282

@@ -98,7 +98,7 @@ Copyright (c) 2016-present, Digipolis
9898

9999
<!-- Generic Links -->
100100
[acpaas-ui]: https://acpaas-ui.digipolis.be
101-
[acpaas-ui-slack]: https://dgpls.slack.com/messages/C4M60PQJF
101+
[acpaas-ui-slack]: https://digantcafe.slack.com/messages/CDDLYJU65/
102102
[flexboxgrid]: https://github.com/a-ui/core_flexboxgrid_scss
103103

104104
<!-- Travis -->

angular.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -765,7 +765,7 @@
765765
"project": "packages/utils/ng-package.prod.json"
766766
},
767767
"examples": {
768-
"project": "packages/avatar/ng-package.examples.json"
768+
"project": "packages/utils/ng-package.examples.json"
769769
}
770770
}
771771
},

guidelines/ISSUES.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Dear maintainer,
44

5-
To ensure issues are handled correctly and timely, it is paramount to review the issues list at regular intervals. These guidelines are for your convenience to help assess and resolve issues. All maintainers are kindly asked to pitch in and help keep a clean issues list.
5+
To ensure issues are handled correctly and timely, it is paramount that the issues list is reviewed at regular intervals. These guidelines are for your convenience to help assess and resolve issues. All maintainers are kindly asked to pitch in and help keep a clean issues list.
66

77
- [Issue Handling Guidelines](#issue-handling-guidelines)
88
- [Issue labels](#issue-labels)
@@ -33,7 +33,8 @@ At regular intervals review the open issues list and **verify for every issue**:
3333
- The label `verified` is applied when a maintainer has reproduced it or verified it is reproduceable.
3434
- Feel free to try reproducing yourself.
3535
- Features and verified bug reports are on some team's roadmap, assigned to a developer, or marked as `help wanted`. (See the guidelines below for assigning.)
36-
- And issues with label `help wanted` that are good for first-time contributors have the label `good first issue`.
36+
- Issues with label `help wanted` that are good for first-time contributors should have the label `good first issue`.
37+
- For issues assigned to a person or team managed in JIRA, a corresponding JIRA issue should be created and linked to from the issue's description or comments.
3738
- Issues that are blocked on additional information have a `missing info` label and a comment asking the appropriate person for the information.
3839
- If the submitter does not respond in a few weeks, you can ping them or close the issue as `invalid`.
3940
- Issues of type `policy` are assigned to someone for resolving.
@@ -50,7 +51,7 @@ For types `bug` and `feature`:
5051
For type `policy`:
5152

5253
- Look for an appropriate maintainer to help resolve this question and assign to them.
53-
- Link to the issue in the [#acpaas-ui-dev](https://dgpls.slack.com/messages/C4S2D7KTK) slack channel if it needs broader discussion.
54+
- Link to the issue in the [#acpaas-ui-ngx](https://digantcafe.slack.com/messages/CDF95H5B7/) slack channel if it needs broader discussion. If you're not yet a member of our DigAnt Café slack community, you can easily [join here](https://digantcafe-slack.digipolis.be).
5455

5556
Contributors are expected to keep an eye on their assigned issues and work towards resolving them. If this is not possible, the maintainers should help find someone else to assign the issue to.
5657

0 commit comments

Comments
 (0)