Skip to content

Loosen peerDependencies versions #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsebrech opened this issue Sep 26, 2018 · 1 comment · Fixed by #94
Closed

Loosen peerDependencies versions #56

jsebrech opened this issue Sep 26, 2018 · 1 comment · Fixed by #94
Assignees
Labels
bug Something isn't working verified This issue has been verified by a maintainer.

Comments

@jsebrech
Copy link
Contributor

Describe the bug

Currently peerDependencies lists very specific versions. In projects that include these dependencies but in different versions we get peer dependency warnings whereas actually it works just fine.

"peerDependencies": {
    "@a-ui/core": "~2.3.0",
    "@a-ui/flexboxgrid": "~1.0.0",
    "@angular/animations": "~6.1.0",
    "@angular/common": "~6.1.0",
    "@angular/core": "~6.1.0",
    "@angular/forms": "~6.1.0",
    "@angular/http": "~6.1.0",
    "@angular/language-service": "~6.1.0",
    "@angular/platform-browser": "~6.1.0",
    "@angular/platform-browser-dynamic": "~6.1.0",
    "@angular/router": "~6.1.0",
    "rxjs": "~6.1.0",
    "rxjs-compat": "~6.1.0",
    "typescript": "~2.7.2"
},

Expected behavior

Less restrictive peerDependencies:

  • @angular: ^6.0.0 to specify the entire angular 6 line is ok (or if there was some requirement in 6.1, use ^6.1.0)
  • rxjs: same
    etc...
@jsebrech jsebrech added the bug Something isn't working label Sep 26, 2018
@jsebrech
Copy link
Contributor Author

Also might be a good opportunity to remove rxjs-compat from the peerDependencies list.

@TriangleJuice TriangleJuice added the verified This issue has been verified by a maintainer. label Nov 5, 2018
@TriangleJuice TriangleJuice mentioned this issue Nov 20, 2018
15 tasks
@TriangleJuice TriangleJuice self-assigned this Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified This issue has been verified by a maintainer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants