From 08d8da506d55f16f3d6a9d312884221c053b5fef Mon Sep 17 00:00:00 2001 From: Jasper Van Proeyen Date: Fri, 16 Nov 2018 16:00:50 +0100 Subject: [PATCH 1/2] Added fix for an unwanted 404 page when the styleguide was reloaded on GitHub pages. --- CHANGELOG.md | 3 +++ angular.json | 6 ++++-- styleguide/404.html | 23 +++++++++++++++++++++++ styleguide/index.html | 17 +++++++++++++++++ 4 files changed, 47 insertions(+), 2 deletions(-) create mode 100644 styleguide/404.html diff --git a/CHANGELOG.md b/CHANGELOG.md index 23abb0b22..0948272ff 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/). ## Unreleased +### Fixed +- `core` Fixed an issue where an unwanted 404 was shown when the styleguide was reloaded on GitHub pages. + ## [1.0.5] - 2018-11-13 diff --git a/angular.json b/angular.json index c50fdb1bc..115468d11 100644 --- a/angular.json +++ b/angular.json @@ -20,7 +20,8 @@ "tsConfig": "styleguide/tsconfig.app.json", "assets": [ "styleguide/favicon.ico", - "styleguide/assets" + "styleguide/assets", + "404.html" ], "styles": [ "styleguide/styles.scss", @@ -87,7 +88,8 @@ "scripts": [], "assets": [ "styleguide/favicon.ico", - "styleguide/assets" + "styleguide/assets", + "404.html" ] } }, diff --git a/styleguide/404.html b/styleguide/404.html new file mode 100644 index 000000000..d6b3996a6 --- /dev/null +++ b/styleguide/404.html @@ -0,0 +1,23 @@ + + + + + Acpaas UI | Angular Modules + + + + + + + +               +               +               +               +               +               + + diff --git a/styleguide/index.html b/styleguide/index.html index 0b3ee947f..9ae8de720 100644 --- a/styleguide/index.html +++ b/styleguide/index.html @@ -15,6 +15,23 @@ + + + From a8fd41acdc4cdc2c5f50869b3df05b41b146073f Mon Sep 17 00:00:00 2001 From: Jasper Van Proeyen Date: Fri, 16 Nov 2018 17:01:01 +0100 Subject: [PATCH 2/2] fix(core): Small (necessary) change to angular.json file --- angular.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/angular.json b/angular.json index 115468d11..8c86b737e 100644 --- a/angular.json +++ b/angular.json @@ -21,7 +21,7 @@ "assets": [ "styleguide/favicon.ico", "styleguide/assets", - "404.html" + "styleguide/404.html" ], "styles": [ "styleguide/styles.scss", @@ -89,7 +89,7 @@ "assets": [ "styleguide/favicon.ico", "styleguide/assets", - "404.html" + "styleguide/404.html" ] } },