File tree 3 files changed +18
-9
lines changed
3 files changed +18
-9
lines changed Original file line number Diff line number Diff line change @@ -75,6 +75,20 @@ export function initGlobalButtonClickOnEnter() {
75
75
} ) ;
76
76
}
77
77
78
+ export function initPopup ( target ) {
79
+ const $el = $ ( target ) ;
80
+ const attr = $el . attr ( 'data-variation' ) ;
81
+ const attrs = attr ? attr . split ( ' ' ) : [ ] ;
82
+ const variations = new Set ( [ ...attrs , 'inverted' , 'tiny' ] ) ;
83
+ $el . attr ( 'data-variation' , [ ...variations ] . join ( ' ' ) ) . popup ( ) ;
84
+ }
85
+
86
+ export function initGlobalPopups ( ) {
87
+ $ ( '.tooltip' ) . each ( ( _ , el ) => {
88
+ initPopup ( el ) ;
89
+ } ) ;
90
+ }
91
+
78
92
export function initGlobalCommon ( ) {
79
93
// Show exact time
80
94
$ ( '.time-since' ) . each ( function ( ) {
@@ -121,15 +135,6 @@ export function initGlobalCommon() {
121
135
122
136
$ ( '.ui.checkbox' ) . checkbox ( ) ;
123
137
124
- // init popups
125
- $ ( '.tooltip' ) . each ( ( _ , el ) => {
126
- const $el = $ ( el ) ;
127
- const attr = $el . attr ( 'data-variation' ) ;
128
- const attrs = attr ? attr . split ( ' ' ) : [ ] ;
129
- const variations = new Set ( [ ...attrs , 'inverted' , 'tiny' ] ) ;
130
- $el . attr ( 'data-variation' , [ ...variations ] . join ( ' ' ) ) . popup ( ) ;
131
- } ) ;
132
-
133
138
$ ( '.top.menu .tooltip' ) . popup ( {
134
139
onShow ( ) {
135
140
if ( $ ( '.top.menu .menu.transition' ) . hasClass ( 'visible' ) ) {
Original file line number Diff line number Diff line change @@ -3,6 +3,7 @@ import {initCompReactionSelector} from './comp/ReactionSelector.js';
3
3
import { initRepoIssueContentHistory } from './repo-issue-content.js' ;
4
4
import { validateTextareaNonEmpty } from './comp/EasyMDE.js' ;
5
5
import { initViewedCheckboxListenerFor , countAndUpdateViewedFiles } from './pull-view-file.js' ;
6
+ import { initPopup } from './common-global.js' ;
6
7
7
8
const { csrfToken} = window . config ;
8
9
@@ -52,6 +53,7 @@ export function initRepoDiffConversationForm() {
52
53
const newConversationHolder = $ ( await $ . post ( form . attr ( 'action' ) , form . serialize ( ) ) ) ;
53
54
const { path, side, idx} = newConversationHolder . data ( ) ;
54
55
56
+ initPopup ( newConversationHolder . find ( '.tooltip' ) ) ;
55
57
form . closest ( '.conversation-holder' ) . replaceWith ( newConversationHolder ) ;
56
58
if ( form . closest ( 'tr' ) . data ( 'line-type' ) === 'same' ) {
57
59
$ ( `[data-path="${ path } "] a.add-code-comment[data-idx="${ idx } "]` ) . addClass ( 'invisible' ) ;
Original file line number Diff line number Diff line change @@ -56,6 +56,7 @@ import {
56
56
initGlobalFormDirtyLeaveConfirm ,
57
57
initGlobalLinkActions ,
58
58
initHeadNavbarContentToggle ,
59
+ initGlobalPopups ,
59
60
} from './features/common-global.js' ;
60
61
import { initRepoTopicBar } from './features/repo-home.js' ;
61
62
import { initAdminEmails } from './features/admin-emails.js' ;
@@ -99,6 +100,7 @@ initVueEnv();
99
100
$ ( document ) . ready ( ( ) => {
100
101
initGlobalCommon ( ) ;
101
102
103
+ initGlobalPopups ( ) ;
102
104
initGlobalButtonClickOnEnter ( ) ;
103
105
initGlobalButtons ( ) ;
104
106
initGlobalCopyToClipboardListener ( ) ;
You can’t perform that action at this time.
0 commit comments