Skip to content

Commit 201a65b

Browse files
DanielDaniel
Daniel
authored and
Daniel
committed
Update binary parameter test
1 parent a112999 commit 201a65b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tests/panels/test_sql.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,20 +122,21 @@ def test_param_conversion(self):
122122
'["2017-12-22 16:07:01"]'
123123
))
124124

125-
@unittest.skipUnless(connection.vendor not in ('sqlite', 'postgresql'), '')
125+
@unittest.skipIf(connection.vendor in ('sqlite', 'postgresql'),
126+
'Mixing bytestrings and text is not allowed on PostgreSQL and SQLite')
126127
def test_binary_param_force_text(self):
127128
self.assertEqual(len(self.panel._queries), 0)
128129

129130
with connection.cursor() as cursor:
130131
cursor.execute("SELECT * FROM auth_user WHERE username = %s", [b'\xff'])
131132

132133
self.assertEqual(len(self.panel._queries), 1)
134+
self.assertEqual(self.panel._queries[0][1]['sql'], "SELECT * FROM auth_user WHERE username = '\ufffd'")
133135

134136
self.panel.process_response(self.request, self.response)
135137
self.panel.generate_stats(self.request, self.response)
136138

137-
@unittest.skipUnless(connection.vendor != 'sqlite',
138-
'Test invalid for SQLite')
139+
@unittest.skipUnless(connection.vendor != 'sqlite', 'Test invalid for SQLite')
139140
def test_raw_query_param_conversion(self):
140141
self.assertEqual(len(self.panel._queries), 0)
141142

0 commit comments

Comments
 (0)