Skip to content

Commit e91ba20

Browse files
rileyajonesdna2github
authored andcommitted
Feature: Add a tooltip to the runs table experiment name column (tensorflow#6097)
## Motivation for features / changes For Googlers b/259431435 We abbreviate the name of the experiment which can lead to confusion. By showing the full name in a tooltip we provide users a way of accessing that information. ## Technical description of changes Tooltips are generally created by setting the `title` attribute. However, this particular column is a custom element and thus required me to pass the attribute through. ## Screenshots of UI changes IDK how to screenshot tooltips 🤷 ## Detailed steps to verify changes work correctly (as executed by you) I tested this on internal tensorboard where the experiment column gets used.
1 parent 6b05c0c commit e91ba20

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

tensorboard/webapp/runs/views/runs_table/runs_table_component.ng.html

+1
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@
244244
<tb-experiment-alias
245245
*ngSwitchCase="RunsTableColumn.EXPERIMENT_NAME"
246246
[alias]="item.experimentAlias"
247+
[title]="item.experimentName"
247248
></tb-experiment-alias>
248249

249250
<span *ngSwitchCase="RunsTableColumn.RUN_NAME" class="name"

tensorboard/webapp/widgets/experiment_alias/experiment_alias_component.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ import {ExperimentAlias} from '../../experiments/types';
3131
(onValueChange)="aliasChanged.emit($event)"
3232
></content-wrapping-input>
3333
<ng-template #noEditAliasName>
34-
<span [class.illegal]="!isAliasNameLegal">{{ alias.aliasText }}</span>
34+
<span [class.illegal]="!isAliasNameLegal" [title]="title">{{
35+
alias.aliasText
36+
}}</span>
3537
</ng-template>
3638
`,
3739
styleUrls: [`experiment_alias_component.css`],
@@ -43,6 +45,9 @@ export class ExperimentAliasComponent {
4345
@Input()
4446
aliasEditable!: boolean;
4547

48+
@Input()
49+
title?: string;
50+
4651
@Input()
4752
isAliasNameLegal: boolean = true;
4853

0 commit comments

Comments
 (0)