Add GetPath on namespace config

Signed-off-by: Michael Crosby <[email protected]>

Author: crosbymichael

configs/namespaces.go

@@ -1,6 +1,7 @@
 package configs
 
 import (
+	"fmt"
 	"syscall"
 )
 
@@ -26,6 +27,32 @@ func (n *Namespace) Syscall() int {
 	return namespaceInfo[n.Type]
 }
 
+func (n *Namespace) GetPath(pid int) string {
+	if n.Path != "" {
+		return n.Path
+	}
+	return fmt.Sprintf("/proc/%d/ns/%s", pid, n.file())
+}
+
+func (n *Namespace) file() string {
+	file := ""
+	switch n.Type {
+	case NEWNET:
+		file = "net"
+	case NEWNS:
+		file = "mnt"
+	case NEWPID:
+		file = "pid"
+	case NEWIPC:
+		file = "ipc"
+	case NEWUSER:
+		file = "user"
+	case NEWUTS:
+		file = "uts"
+	}
+	return file
+}
+
 type Namespaces []Namespace
 
 func (n *Namespaces) Remove(t NamespaceType) bool {

console.go

@@ -2,7 +2,7 @@ package libcontainer
 
 import "io"
 
-// Console represents a psuedo TTY.
+// Console represents a pseudo TTY.
 type Console interface {
 	io.ReadWriter
 	io.Closer

linux_container.go

@@ -72,26 +72,7 @@ func (c *linuxContainer) State() (*State, error) {
 		NamespacePaths:       make(map[string]string),
 	}
 	for _, ns := range c.config.Namespaces {
-		if ns.Path != "" {
-			state.NamespacePaths[string(ns.Type)] = ns.Path
-			continue
-		}
-		file := ""
-		switch ns.Type {
-		case configs.NEWNET:
-			file = "net"
-		case configs.NEWNS:
-			file = "mnt"
-		case configs.NEWPID:
-			file = "pid"
-		case configs.NEWIPC:
-			file = "ipc"
-		case configs.NEWUSER:
-			file = "user"
-		case configs.NEWUTS:
-			file = "uts"
-		}
-		state.NamespacePaths[string(ns.Type)] = fmt.Sprintf("/proc/%d/ns/%s", c.initProcess.pid(), file)
+		state.NamespacePaths[string(ns.Type)] = ns.GetPath(c.initProcess.pid())
 	}
 	return state, nil
 }

nsinit/config.go

@@ -13,7 +13,7 @@ import (
 )
 
 var createFlags = []cli.Flag{
-	cli.IntFlag{Name: "parent-death-signal", Usage: "set the signal that will be delivered to the process incase the parent dies"},
+	cli.IntFlag{Name: "parent-death-signal", Usage: "set the signal that will be delivered to the process in case the parent dies"},
 	cli.BoolFlag{Name: "read-only", Usage: "set the container's rootfs as read-only"},
 	cli.StringSliceFlag{Name: "bind", Value: &cli.StringSlice{}, Usage: "add bind mounts to the container"},
 	cli.StringSliceFlag{Name: "tmpfs", Value: &cli.StringSlice{}, Usage: "add tmpfs mounts to the container"},