Skip to content

Commit 48cfe21

Browse files
authored
Merge pull request #5456 from laurazard/fix-defer-mp-shutdown
telemetry: fix early meterprovider shutdown
2 parents a5fb752 + 1355d7e commit 48cfe21

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

cmd/docker/docker.go

+5-3
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,11 @@ func runDocker(ctx context.Context, dockerCli *command.DockerCli) error {
358358

359359
mp := dockerCli.MeterProvider()
360360
if mp, ok := mp.(command.MeterProvider); ok {
361-
if err := mp.Shutdown(ctx); err != nil {
362-
otel.Handle(err)
363-
}
361+
defer func() {
362+
if err := mp.Shutdown(ctx); err != nil {
363+
otel.Handle(err)
364+
}
365+
}()
364366
} else {
365367
fmt.Fprint(dockerCli.Err(), "Warning: Unexpected OTEL error, metrics may not be flushed")
366368
}

0 commit comments

Comments
 (0)