Skip to content

Commit cf81f3c

Browse files
Apply suggestions from code review
Co-authored-by: Chris Crone <[email protected]>
1 parent c7752c1 commit cf81f3c

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

engine/context/ecs-integration.md

+10-9
Original file line numberDiff line numberDiff line change
@@ -351,19 +351,24 @@ the ARN of an existing LoadBalancer.
351351
The latter can be used for those who want to customize application exposure, typically to
352352
use an existing domain name for your application:
353353

354-
1. Use AWS web console or CLI to get your VPC and Subnets IDs. You can typically retrieve default VPC ID and attached subnets using this AWS CLI commands:
354+
1. Use the AWS web console or CLI to get your VPC and Subnets IDs. You can retrieve the default VPC ID and attached subnets using this AWS CLI commands:
355+
355356
```console
356-
➜ aws ec2 describe-vpcs --filters Name=isDefault,Values=true --query 'Vpcs[0].VpcId'
357+
$ aws ec2 describe-vpcs --filters Name=isDefault,Values=true --query 'Vpcs[0].VpcId'
358+
357359
"vpc-123456"
358-
➜ aws ec2 describe-subnets --filters Name=vpc-id,Values=vpc-123456 --query 'Subnets[*].SubnetId'
360+
$ aws ec2 describe-subnets --filters Name=vpc-id,Values=vpc-123456 --query 'Subnets[*].SubnetId'
361+
359362
[
360363
"subnet-1234abcd",
361364
"subnet-6789ef00",
362365
]
363366
```
364-
1. Use AWS CLI to create your load balancer. The AWS Web Console can also be used but will require to assing at least one listener, which we don't need here.
367+
1. Use the AWS CLI to create your load balancer. The AWS Web Console can also be used but will require adding at least one listener, which we don't need here.
368+
365369
```console
366-
➜ tutu aws elbv2 create-load-balancer --name myloadbalancer --type application --subnets "subnet-1234abcd" "subnet-6789ef00"
370+
$ aws elbv2 create-load-balancer --name myloadbalancer --type application --subnets "subnet-1234abcd" "subnet-6789ef00"
371+
367372
{
368373
"LoadBalancers": [
369374
{
@@ -380,9 +385,6 @@ CNAME entry pointing to just-created loadbalancer's `DNSName` reported as you cr
380385

381386
Please note Docker ECS integration won't be aware of this domain name, so `docker compose ps` command will report URLs with loadbalancer DNSName, not your own domain.
382387

383-
384-
385-
386388
You also can use `external: true` inside a network definition in your Compose file for
387389
Docker Compose CLI to _not_ create a Security Group, and set `name` with the
388390
ID of an existing SecurityGroup you want to use for network connectivity between
@@ -395,7 +397,6 @@ networks:
395397
name: "sg-1234acbd"
396398
```
397399

398-
399400
## Local simulation
400401

401402
When you deploy your application on ECS, you may also rely on the additional AWS services.

0 commit comments

Comments
 (0)