From 5f7b4b1fe8366d86b003ecac714ea4adc0227c4c Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Tue, 16 Mar 2021 18:50:20 +0530 Subject: [PATCH 1/2] chore: bump cli-prompts-test --- package-lock.json | 12 ++++++------ package.json | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package-lock.json b/package-lock.json index 997f406..7535269 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1047,9 +1047,9 @@ } }, "cli-prompts-test": { - "version": "0.2.0", - "resolved": "https://registry.npmjs.org/cli-prompts-test/-/cli-prompts-test-0.2.0.tgz", - "integrity": "sha512-1Jwc1kEA/bWwHfJtPMdqq4S6J7nghlVMF1XsakqURjP5ngeXB4LMLHmMbdBS5DS4GlIzWLry+2WEr2mvNSlhlg==", + "version": "0.3.0", + "resolved": "https://registry.npmjs.org/cli-prompts-test/-/cli-prompts-test-0.3.0.tgz", + "integrity": "sha512-qVbbJewDhmjVHc0fAE76ydsYvIdSaxazbwXlLX9cavCkBugnKMZ6CHyeAaZvhGQ+RRd4Skp+6yy953sxIaYatw==", "dev": true, "requires": { "concat-stream": "^2.0.0", @@ -1057,9 +1057,9 @@ }, "dependencies": { "execa": { - "version": "4.0.3", - "resolved": "https://registry.npmjs.org/execa/-/execa-4.0.3.tgz", - "integrity": "sha512-WFDXGHckXPWZX19t1kCsXzOpqX9LWYNqn4C+HqZlk/V0imTkzJZqf87ZBhvpHaftERYknpk0fjSylnXVlVgI0A==", + "version": "4.1.0", + "resolved": "https://registry.npmjs.org/execa/-/execa-4.1.0.tgz", + "integrity": "sha512-j5W0//W7f8UxAn8hXVnwG8tLwdiUy4FJLcSupCg6maBYZDpyBvTApK7KyuI4bKj8KOh1r2YH+6ucuYtJv1bTZA==", "dev": true, "requires": { "cross-spawn": "^7.0.0", diff --git a/package.json b/package.json index e5090ca..5373dc6 100644 --- a/package.json +++ b/package.json @@ -72,7 +72,7 @@ }, "devDependencies": { "ava": "^3.13.0", - "cli-prompts-test": "^0.2.0", + "cli-prompts-test": "^0.3.0", "cors": "^2.8.1", "eslint": "^6.8.0", "eslint-config-xo-space": "^0.22.0", From abfe07d97caf43de31a5242c9221a0f31530268d Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Tue, 16 Mar 2021 18:50:59 +0530 Subject: [PATCH 2/2] test: assert for exit code --- e2e/commands/generate.test.js | 6 +++++- e2e/commands/init.test.js | 13 +++++++++++-- lib/commands/generate.js | 1 + 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/e2e/commands/generate.test.js b/e2e/commands/generate.test.js index 4892e15..cb60bef 100644 --- a/e2e/commands/generate.test.js +++ b/e2e/commands/generate.test.js @@ -26,6 +26,10 @@ test('generate _sidebar.md', t => { // Check for existence t.true(fs.existsSync(path.join(docsPath, '_sidebar.md'))) - const {stderr} = run(['generate', 'docs'], {cwd: genPath}) + const {exitCode, stderr} = run(['generate', 'docs'], { + cwd: genPath, + reject: false + }) + t.is(exitCode, 1) t.is(stderr, 'The sidebar file \'_sidebar.md\' already exists.') }) diff --git a/e2e/commands/init.test.js b/e2e/commands/init.test.js index f2cab51..035adf7 100644 --- a/e2e/commands/init.test.js +++ b/e2e/commands/init.test.js @@ -22,13 +22,22 @@ test.after('cleanup', () => { }) test('generates docs directory', t => { - run(['init', 'docs'], {cwd: genPath}) + const {exitCode} = run(['init', 'docs'], {cwd: genPath}) + + // Assert for exit code + t.is(exitCode, 0) + // Check for existence t.true(fs.existsSync(path.join(docsPath, 'README.md'))) t.true(fs.existsSync(path.join(docsPath, 'index.html'))) }) test('force generates docs directory with --local flag', async t => { - await runPromptWithAnswers(['init', 'docs', '--local'], ['y', ENTER], genPath) + const {exitCode} = await runPromptWithAnswers( + ['init', 'docs', '--local'], + ['y', ENTER], + genPath + ) + t.is(exitCode, 0) t.true(fs.existsSync(path.join(docsPath, 'vendor'))) }) diff --git a/lib/commands/generate.js b/lib/commands/generate.js index df572dc..92b4635 100644 --- a/lib/commands/generate.js +++ b/lib/commands/generate.js @@ -22,6 +22,7 @@ module.exports = function (path = '', sidebar) { } console.error(chalk.red(`The sidebar file '${sidebar}' already exists.`)) + process.exitCode = 1 return false } }