Skip to content

Commit 5a67282

Browse files
tmcwtmcw
committed
Nail down bugfix. Fixes #556 
1 parent a1eb45d commit 5a67282

File tree

4 files changed

+554
-14
lines changed

4 files changed

+554
-14
lines changed

Diff for: ‎test/fixture/es6-class.input.js

+19-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,22 @@
11
/**
2-
* This will fail.
2+
* This is my component. This is from issue #458
33
*/
44
class Foo extends React.Component {}
5+
6+
/**
7+
* Does nothing. This is from issue #556
8+
*/
9+
export default class Bar {
10+
11+
/**
12+
* Creates a new instance
13+
* @param {string} str
14+
*/
15+
constructor(str) {
16+
/**
17+
* A useless property
18+
* @type {string}
19+
*/
20+
this.bar = "";
21+
}
22+
}

Diff for: ‎test/fixture/es6-class.output.json

+325-7
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"children": [
99
{
1010
"type": "text",
11-
"value": "This will fail.",
11+
"value": "This is my component. This is from issue #458",
1212
"position": {
1313
"start": {
1414
"line": 1,
@@ -17,8 +17,8 @@
1717
},
1818
"end": {
1919
"line": 1,
20-
"column": 16,
21-
"offset": 15
20+
"column": 46,
21+
"offset": 45
2222
},
2323
"indent": []
2424
}
@@ -32,8 +32,8 @@
3232
},
3333
"end": {
3434
"line": 1,
35-
"column": 16,
36-
"offset": 15
35+
"column": 46,
36+
"offset": 45
3737
},
3838
"indent": []
3939
}
@@ -47,8 +47,8 @@
4747
},
4848
"end": {
4949
"line": 1,
50-
"column": 16,
51-
"offset": 15
50+
"column": 46,
51+
"offset": 45
5252
}
5353
}
5454
},
@@ -95,5 +95,323 @@
9595
}
9696
],
9797
"namespace": "Foo"
98+
},
99+
{
100+
"description": {
101+
"type": "root",
102+
"children": [
103+
{
104+
"type": "paragraph",
105+
"children": [
106+
{
107+
"type": "text",
108+
"value": "Does nothing. This is from issue #556",
109+
"position": {
110+
"start": {
111+
"line": 1,
112+
"column": 1,
113+
"offset": 0
114+
},
115+
"end": {
116+
"line": 1,
117+
"column": 38,
118+
"offset": 37
119+
},
120+
"indent": []
121+
}
122+
}
123+
],
124+
"position": {
125+
"start": {
126+
"line": 1,
127+
"column": 1,
128+
"offset": 0
129+
},
130+
"end": {
131+
"line": 1,
132+
"column": 38,
133+
"offset": 37
134+
},
135+
"indent": []
136+
}
137+
}
138+
],
139+
"position": {
140+
"start": {
141+
"line": 1,
142+
"column": 1,
143+
"offset": 0
144+
},
145+
"end": {
146+
"line": 1,
147+
"column": 38,
148+
"offset": 37
149+
}
150+
}
151+
},
152+
"tags": [],
153+
"loc": {
154+
"start": {
155+
"line": 6,
156+
"column": 0
157+
},
158+
"end": {
159+
"line": 8,
160+
"column": 3
161+
}
162+
},
163+
"context": {
164+
"loc": {
165+
"start": {
166+
"line": 9,
167+
"column": 0
168+
},
169+
"end": {
170+
"line": 22,
171+
"column": 1
172+
}
173+
}
174+
},
175+
"errors": [],
176+
"name": "Bar",
177+
"kind": "class",
178+
"members": {
179+
"instance": [
180+
{
181+
"description": {
182+
"type": "root",
183+
"children": [
184+
{
185+
"type": "paragraph",
186+
"children": [
187+
{
188+
"type": "text",
189+
"value": "Creates a new instance",
190+
"position": {
191+
"start": {
192+
"line": 1,
193+
"column": 1,
194+
"offset": 0
195+
},
196+
"end": {
197+
"line": 1,
198+
"column": 23,
199+
"offset": 22
200+
},
201+
"indent": []
202+
}
203+
}
204+
],
205+
"position": {
206+
"start": {
207+
"line": 1,
208+
"column": 1,
209+
"offset": 0
210+
},
211+
"end": {
212+
"line": 1,
213+
"column": 23,
214+
"offset": 22
215+
},
216+
"indent": []
217+
}
218+
}
219+
],
220+
"position": {
221+
"start": {
222+
"line": 1,
223+
"column": 1,
224+
"offset": 0
225+
},
226+
"end": {
227+
"line": 1,
228+
"column": 23,
229+
"offset": 22
230+
}
231+
}
232+
},
233+
"tags": [
234+
{
235+
"title": "param",
236+
"description": null,
237+
"lineNumber": 2,
238+
"type": {
239+
"type": "NameExpression",
240+
"name": "string"
241+
},
242+
"name": "str"
243+
}
244+
],
245+
"loc": {
246+
"start": {
247+
"line": 11,
248+
"column": 4
249+
},
250+
"end": {
251+
"line": 14,
252+
"column": 7
253+
}
254+
},
255+
"context": {
256+
"loc": {
257+
"start": {
258+
"line": 15,
259+
"column": 4
260+
},
261+
"end": {
262+
"line": 21,
263+
"column": 5
264+
}
265+
}
266+
},
267+
"errors": [],
268+
"params": [
269+
{
270+
"name": "str",
271+
"lineNumber": 2,
272+
"type": {
273+
"type": "NameExpression",
274+
"name": "string"
275+
}
276+
}
277+
],
278+
"name": "constructor",
279+
"kind": "function",
280+
"memberof": "Bar",
281+
"scope": "instance",
282+
"members": {
283+
"instance": [],
284+
"static": []
285+
},
286+
"path": [
287+
{
288+
"name": "Bar",
289+
"kind": "class"
290+
},
291+
{
292+
"name": "constructor",
293+
"kind": "function",
294+
"scope": "instance"
295+
}
296+
],
297+
"namespace": "Bar#constructor"
298+
},
299+
{
300+
"description": {
301+
"type": "root",
302+
"children": [
303+
{
304+
"type": "paragraph",
305+
"children": [
306+
{
307+
"type": "text",
308+
"value": "A useless property",
309+
"position": {
310+
"start": {
311+
"line": 1,
312+
"column": 1,
313+
"offset": 0
314+
},
315+
"end": {
316+
"line": 1,
317+
"column": 19,
318+
"offset": 18
319+
},
320+
"indent": []
321+
}
322+
}
323+
],
324+
"position": {
325+
"start": {
326+
"line": 1,
327+
"column": 1,
328+
"offset": 0
329+
},
330+
"end": {
331+
"line": 1,
332+
"column": 19,
333+
"offset": 18
334+
},
335+
"indent": []
336+
}
337+
}
338+
],
339+
"position": {
340+
"start": {
341+
"line": 1,
342+
"column": 1,
343+
"offset": 0
344+
},
345+
"end": {
346+
"line": 1,
347+
"column": 19,
348+
"offset": 18
349+
}
350+
}
351+
},
352+
"tags": [
353+
{
354+
"title": "type",
355+
"description": null,
356+
"lineNumber": 2,
357+
"type": {
358+
"type": "NameExpression",
359+
"name": "string"
360+
}
361+
}
362+
],
363+
"loc": {
364+
"start": {
365+
"line": 16,
366+
"column": 8
367+
},
368+
"end": {
369+
"line": 19,
370+
"column": 11
371+
}
372+
},
373+
"context": {
374+
"loc": {
375+
"start": {
376+
"line": 20,
377+
"column": 8
378+
},
379+
"end": {
380+
"line": 20,
381+
"column": 22
382+
}
383+
}
384+
},
385+
"errors": [],
386+
"name": "bar",
387+
"memberof": "Bar",
388+
"scope": "instance",
389+
"members": {
390+
"instance": [],
391+
"static": []
392+
},
393+
"path": [
394+
{
395+
"name": "Bar",
396+
"kind": "class"
397+
},
398+
{
399+
"name": "bar",
400+
"scope": "instance"
401+
}
402+
],
403+
"namespace": "Bar#bar"
404+
}
405+
],
406+
"static": [],
407+
"events": []
408+
},
409+
"path": [
410+
{
411+
"name": "Bar",
412+
"kind": "class"
413+
}
414+
],
415+
"namespace": "Bar"
98416
}
99417
]

0 commit comments

Comments
 (0)