Skip to content

System.import() is ignored #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vadirn opened this issue Oct 24, 2016 · 3 comments
Closed

System.import() is ignored #578

vadirn opened this issue Oct 24, 2016 · 3 comments

Comments

@vadirn
Copy link

vadirn commented Oct 24, 2016

Beta of webpack 2 supports System.import() to load modules on demand. Files imported this way are ignored when generating documentation.

Are there any workarounds for this issue? documentation build ./src/* doesn't help

@tmcw
Copy link
Member

tmcw commented Oct 24, 2016

Thanks for the report! Helpful to get the changing lay of the land from webpack world :)

In terms of workarounds: documentation build ./src/* - documentation.js uses your terminal's globbing pattern, so unless all of your files are directly in src, that won't include all of them. documentation build ./src/**.js should work.

In terms of supporting this in documentation.js (and I'll keep this ticket issue to track that task), we'll need module-deps to be able to detect and follow these references.

@tmcw
Copy link
Member

tmcw commented Nov 18, 2016

https://github.com/thgreasi/babel-plugin-system-import-transformer does the trick. Given that webpack documents System.import, I'm thinking people will use the API. But it's one of many import/require variations going around (kids these days! get off my lawn), so if it fades from popularity, I reserve the right to remove support :)

Thanks @thgreasi for implementing babel-plugin-system-import-transformer, works like a charm!

@thgreasi
Copy link

@tmcw I'm glad that it proved useful for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants