Skip to content

Build fails for arm/v7 due to Int/uint overflows #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kylebrandt opened this issue Feb 3, 2025 · 3 comments · May be fixed by #2987
Open

Build fails for arm/v7 due to Int/uint overflows #2837

kylebrandt opened this issue Feb 3, 2025 · 3 comments · May be fixed by #2987
Labels
customer issue

Comments

@kylebrandt
Copy link
Contributor

When building with for arm, get some overflow errors on some constants.

Output:

Stderr:
# github.com/dolthub/go-mysql-server/sql/types
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/geometry.go:548:24: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1123:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1128:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1133:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1138:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1143:18: math.MaxUint64 (untyped int constant 18446744073709551615) overflows uint
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1214:17: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1221:22: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1228:22: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1235:22: math.MaxUint32 (untyped int constant 4294967295) overflows int
/go/pkg/mod/github.com/dolthub/[email protected]/sql/types/number.go:1235:22: too many errors
@kylebrandt kylebrandt mentioned this issue Feb 3, 2025
Merged
17 tasks
@twaik
Copy link

twaik commented Apr 23, 2025

Reproducible with go1.24.1.linux-amd64 while cross-compiling for bionic i686 target.
CI run: https://github.com/termux/termux-packages/actions/runs/14625433243/job/41035684818 .

@twaik
Copy link

twaik commented Apr 23, 2025

Same happens with go1.24.2.

@timsehn
Copy link
Contributor

timsehn commented Apr 23, 2025

We don't use these systems but we'd happily take a contribution here.

@twaik twaik mentioned this issue Apr 23, 2025
Merged
thunder-coding added a commit to termux/termux-packages that referenced this issue May 21, 2025
@thunder-coding
fix(main/grafana): fix builds for i686
0f6c62f 
This patch should fix builds for i686 architecture and fixes an upstream
issue dolthub/go-mysql-server#2837
This was referenced May 21, 2025
Merged
Open
thunder-coding added a commit to termux/termux-packages that referenced this issue May 21, 2025
@thunder-coding
fix(main/grafana): fix builds for i686
c015002 
This patch should fix builds for i686 architecture and fixes an upstream
issue dolthub/go-mysql-server#2837
thunder-coding added a commit to termux/termux-packages that referenced this issue May 25, 2025
@thunder-coding
fix(main/grafana): fix builds for i686
3b5ff95 
This patch should fix builds for i686 architecture and fixes an upstream
issue dolthub/go-mysql-server#2837
thunder-coding added a commit to termux/termux-packages that referenced this issue May 26, 2025
@thunder-coding
fix(main/grafana): fix builds for i686
0ef71ca 
This patch should fix builds for i686 architecture and fixes an upstream
issue dolthub/go-mysql-server#2837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix builds for platforms with 32-bit integer size thunder-coding/go-mysql-server
4 participants
@kylebrandt @timsehn @twaik @coffeegoddd