simple: valid struct conversion depends on targeted Go version

Author: dominikh

simple/lint.go

@@ -1011,8 +1011,14 @@ func (c *Checker) LintSimplerStructConversion(j *lint.Job) {
 		if typ1 == typ2 {
 			return true
 		}
-		if !structsIdentical(s1, s2) {
-			return true
+		if IsGoVersion(j, 8) {
+			if !types.IdenticalIgnoreTags(s1, s2) {
+				return true
+			}
+		} else {
+			if !types.Identical(s1, s2) {
+				return true
+			}
 		}
 		j.Errorf(node, "should convert %s (type %s) to %s instead of using struct literal",
 			ident.Name, typ2.Obj().Name(), typ1.Obj().Name())

simple/lint17.go

@@ -0,0 +1,22 @@
+package pkg
+
+type t1 struct {
+	a int
+	b int
+}
+
+type t2 struct {
+	a int
+	b int
+}
+
+type t3 struct {
+	a int `tag`
+	b int `tag`
+}
+
+func fn() {
+	v1 := t1{1, 2}
+	_ = t2{v1.a, v1.b}       // MATCH /should convert v1/
+	_ = t3{v1.a, v1.b}
+}

simple/lint18.go

@@ -0,0 +1,22 @@
+package pkg
+
+type t1 struct {
+	a int
+	b int
+}
+
+type t2 struct {
+	a int
+	b int
+}
+
+type t3 struct {
+	a int `tag`
+	b int `tag`
+}
+
+func fn() {
+	v1 := t1{1, 2}
+	_ = t2{v1.a, v1.b}       // MATCH /should convert v1/
+	_ = t3{v1.a, v1.b}       // MATCH /should convert v1/
+}