[typescript-resolvers] Enums ValueMaps don't get generated anymore

[darkbasic]

Apollo allows you to customize the internal values of your GraphQL enums: https://www.apollographql.com/docs/apollo-server/schema/scalars-enums/

That means that in you resolvers you will do something like this:

const resolvers: Resolvers = {
  Sex: {
    MALE: 0,
    FEMALE: 1,
  },
};

Unfortunately that will break the generated types because in Resolvers there will be no property set for the enum field.

Older versions of the codegen generated a ValueMap for each enum so you could do something like this:

type EnumResolvers = {
  Sex?: SexValueMap;
};

const resolvers: Resolvers & EnumResolvers = {
  Sex: {
    MALE: 0,
    FEMALE: 1,
  },
};

where the ValueMap was something like this:

type SexValueMap = {
  MALE: Sex,
  FEMALE: Sex,
};

Since codegen v1 this doesn't work anymore.

It would be nice if support for enums with custom internal values would be re-introduced, but in my opinion it should be done in a slightly different way:

1. The ValueMap should map to the exact value:

type SexValueMap = {
  MALE: Sex.MALE,
  FEMALE: Sex.FEMALE,
};

2. The value map should be automatically added to the Resolvers type, in order to avoid doing the following:

type EnumResolvers = {
  Sex?: SexValueMap;
};

const resolvers: Resolvers & EnumResolvers = {}

[dotansimha]

Thank you for reporting this @darkbasic .
@kamilkisiela what do you think? I think we can add it to the signature, shouldn't be too complicated.

[Javadebi]

Is there any solution to fix it?

[Javadebi]

Another problem I have is when i'm trying to use the variable in for example if. sex: Sex
and I say if(sex === 'male') gives type error because in generated schema its defined sex === 'MALE'
is there any solution to this?

[darkbasic]

You want to use if (sex === Sex.MALE) otherwise you will lose most of the benefits anyway.

[Javadebi]

You want to use if (sex === Sex.MALE) otherwise you will lose most of the benefits anyway.

Exactly right now I'm asserting type to values for example I'm saying if(sex === ('male' as Sex)) and I know its very bad but i don't have any other solution