Prefer an element-wise copy over memcpy for fat pointers

We currently copy fat pointers using memcpy intrinsics, which SROA will
split up into load/store pairs. Unfortunately, nonnull metadata on loads
from said fat pointers might get lost in the process. So instead of
using memcpy we can go ahead and use load/store pairs right away
including the appropriate nonnull metadata on the loads. That way the
metadata doesn't get lost and LLVM has better chances of eliminating
null checks.

One example for this is the code in rust-lang#27130 that currently has an extra
null check that disappears after this change.

Author: dotdash

src/librustc_trans/trans/base.rs

@@ -979,7 +979,9 @@ pub fn memcpy_ty<'blk, 'tcx>(bcx: Block<'blk, 'tcx>,
                              t: Ty<'tcx>) {
     let _icx = push_ctxt("memcpy_ty");
     let ccx = bcx.ccx();
-    if t.is_structural() {
+    if common::type_is_fat_ptr(bcx.tcx(), t) {
+        expr::copy_fat_ptr(bcx, src, dst, t);
+    } else if t.is_structural() {
         let llty = type_of::type_of(ccx, t);
         let llsz = llsize_of(ccx, llty);
         let llalign = type_of::align_of(ccx, t);