Skip to content

Commit 730ae19

Browse files
committed
Show legends only for visible columns i.e. hide the time legend when Mean&Error are hidden
1 parent 5bcfaa7 commit 730ae19

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/BenchmarkDotNet/Running/BenchmarkRunnerClean.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,8 +241,11 @@ private static void PrintSummary(ILogger logger, ImmutableConfig config, Summary
241241
ConclusionHelper.Print(logger, config.GetCompositeAnalyser().Analyse(summary).Distinct().ToList());
242242

243243
// TODO: move to conclusions
244-
var columnWithLegends = summary.Table.Columns.Select(c => c.OriginalColumn).Where(c => !string.IsNullOrEmpty(c.Legend)).ToList();
245-
var effectiveTimeUnit = summary.Table.EffectiveSummaryStyle.TimeUnit;
244+
var columnWithLegends = summary.Table.Columns.Where(c => c.NeedToShow).Select(c => c.OriginalColumn).Where(c => !string.IsNullOrEmpty(c.Legend)).ToList();
245+
246+
bool needToShowTimeLegend = summary.Table.Columns.Where(c => c.NeedToShow).Select(c => c.OriginalColumn).Any(c => c.UnitType == UnitType.Time);
247+
var effectiveTimeUnit = needToShowTimeLegend ? summary.Table.EffectiveSummaryStyle.TimeUnit : null;
248+
246249
if (columnWithLegends.Any() || effectiveTimeUnit != null)
247250
{
248251
logger.WriteLine();

0 commit comments

Comments
 (0)