Skip to content

Commit c682d52

Browse files
Skip UserCanSpecifyCustomBuildConfiguration on .NET Framework, see #2376
1 parent 28809a1 commit c682d52

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

tests/BenchmarkDotNet.IntegrationTests/CustomBuildConfigurationTests.cs

+4-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
using BenchmarkDotNet.Extensions;
55
using BenchmarkDotNet.Jobs;
66
using BenchmarkDotNet.Portability;
7+
using BenchmarkDotNet.Tests.XUnit;
8+
#if !DEBUG
79
using Xunit;
10+
#endif
811
using Xunit.Abstractions;
912

1013
namespace BenchmarkDotNet.IntegrationTests
@@ -15,7 +18,7 @@ public CustomBuildConfigurationTests(ITestOutputHelper output) : base(output)
1518
{
1619
}
1720

18-
[Fact]
21+
[FactEnvSpecific("Flaky, see https://github.com/dotnet/BenchmarkDotNet/issues/2376", EnvRequirement.NonFullFramework)]
1922
public void UserCanSpecifyCustomBuildConfiguration()
2023
{
2124
var jobWithCustomConfiguration = Job.Dry.WithCustomBuildConfiguration("CUSTOM");

tests/BenchmarkDotNet.Tests/XUnit/EnvRequirement.cs

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ public enum EnvRequirement
66
NonWindows,
77
NonLinux,
88
FullFrameworkOnly,
9+
NonFullFramework,
910
DotNetCoreOnly,
1011
DotNetCore30Only
1112
}

tests/BenchmarkDotNet.Tests/XUnit/EnvRequirementChecker.cs

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ public static class EnvRequirementChecker
1919
EnvRequirement.NonWindows => !RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? null : "Non-Windows test",
2020
EnvRequirement.NonLinux => !RuntimeInformation.IsOSPlatform(OSPlatform.Linux) ? null : "Non-Linux test",
2121
EnvRequirement.FullFrameworkOnly => BdnRuntimeInformation.IsFullFramework ? null : "Full .NET Framework-only test",
22+
EnvRequirement.NonFullFramework => !BdnRuntimeInformation.IsFullFramework ? null : "Non-Full .NET Framework test",
2223
EnvRequirement.DotNetCoreOnly => BdnRuntimeInformation.IsNetCore ? null : ".NET/.NET Core-only test",
2324
EnvRequirement.DotNetCore30Only => IsRuntime(RuntimeMoniker.NetCoreApp30) ? null : ".NET Core 3.0-only test",
2425
_ => throw new ArgumentOutOfRangeException(nameof(requirement), requirement, "Unknown value")

0 commit comments

Comments
 (0)