Fixed NRE when parameter that does not have model metadata is encountered. Fixes #250

Chris Martinez · Chris Martinez · commit 1ef189973af9 · 2018-02-09T09:55:10.000-08:00
diff --git a/src/Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer/ApiVersionParameterDescriptionContext.cs b/src/Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer/ApiVersionParameterDescriptionContext.cs
@@ -249,7 +249,7 @@ void RemoveAllParametersExcept( ApiParameterDescription parameter )
 
                 foreach ( var otherParameter in otherParameters )
                 {
-                    if ( otherParameter.ModelMetadata.DataTypeName == nameof( ApiVersion ) )
+                    if ( otherParameter.ModelMetadata?.DataTypeName == nameof( ApiVersion ) )
                     {
                         collection.Remove( otherParameter );
                     }
diff --git a/src/Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer/Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer.csproj b/src/Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer/Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer.csproj
@@ -14,6 +14,7 @@
 
  <ItemGroup>
   <ReleaseNotes Include="Support substituting API version parameter in route templates (Issue 247)" />
+  <ReleaseNotes Include="Fix NullReferenceException when parameter without metadata is encountered (Issue 250)" />
  </ItemGroup>
 
  <ItemGroup>

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ void RemoveAllParametersExcept( ApiParameterDescription parameter )`
`249`	`249`
`250`	`250`	`foreach ( var otherParameter in otherParameters )`
`251`	`251`	`{`
`252`		`- if ( otherParameter.ModelMetadata.DataTypeName == nameof( ApiVersion ) )`
	`252`	`+ if ( otherParameter.ModelMetadata?.DataTypeName == nameof( ApiVersion ) )`
`253`	`253`	`{`
`254`	`254`	`collection.Remove( otherParameter );`
`255`	`255`	`}`