Fix broken test from route constraint elimination

Author: commonsensesoftware

test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/Basic/given a versioned Controller/when using a query string and split into two types.cs

@@ -62,15 +62,15 @@ public async Task then_get_with_integer_id_should_return_200()
         }
 
         [Fact]
-        public async Task then_get_returns_400_with_invalid_id()
+        public async Task then_get_returns_404_with_invalid_id()
         {
             // arrange
             var requestUrl = "api/values/abc?api-version=2.0";
 
             // note: the classic routing mechanism cannot disambiguate 400 vs 405
             // because the route constraint {id:int} completely eliminates the
             // candidate; however, endpoint routing works as expected
-            var statusCode = UsingEndpointRouting ? BadRequest : MethodNotAllowed;
+            var statusCode = UsingEndpointRouting ? NotFound : MethodNotAllowed;
 
             // act
             var response = await GetAsync( requestUrl );

test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Mvc/Basic/given a versioned Controller/when using a url segment.cs

@@ -66,15 +66,15 @@ public async Task then_post_should_return_201( string version )
         }
 
         [Fact]
-        public async Task then_get_returns_400_with_invalid_id()
+        public async Task then_get_returns_404_with_invalid_id()
         {
             // arrange
             var requestUrl = "api/v2/helloworld/abc";
 
             // note: the classic routing mechanism cannot disambiguate 400 vs 405
             // because the route constraint {id:int} completely eliminates the
             // candidate; however, endpoint routing works as expected
-            var statusCode = UsingEndpointRouting ? BadRequest : MethodNotAllowed;
+            var statusCode = UsingEndpointRouting ? NotFound : MethodNotAllowed;
 
             // act
             var response = await GetAsync( requestUrl );