Skip to content

Rename ExistingOnly #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1891
jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #1951
Closed
Tracked by #1891

Rename ExistingOnly #1897

jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #1951
Assignees
Labels
Milestone

Comments

@jonsequitur
Copy link
Contributor

jonsequitur commented Nov 2, 2022

    // I'm not sold on the naming around [ExistingOnly], because
    // * Guideline: DO give methods names that are verbs or verb phrases.
    // * Guideline: CONSIDER naming the type that holds extension methods for itsfunctionality—for example, use “Routing” instead of “[ExtendedType]Extensions.”
    //
    // The only existing "ExistingOnly" in the BCL is System.Security.Cryptography.X509Certificates.OpenFlags.OpenExistingOnly, which is an enum member.
    // "AcceptExistingOnly".  "RequirePathExists"
    // Static methods should also consider their static invocation model:  ArgumentExtensions.ExistingOnly(inputFile)... that has no meaning to me.
    // ArgumentValidation.RequirePathExists(inputFile), or ArgumentRestrictions.RequirePathExists(inputFile), or something like that, does.
    public static class ArgumentExtensions 
    {
@jonsequitur jonsequitur mentioned this issue Nov 2, 2022
56 tasks
@jozkee jozkee self-assigned this Nov 4, 2022
@jonsequitur jonsequitur added this to the 2.0 GA milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants