Skip to content

Consider removing Command.AddOption, Command.AddCommand, and Command.AddArgument because they're redundant with Add #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1891
jonsequitur opened this issue Nov 2, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@jonsequitur
Copy link
Contributor

jonsequitur commented Nov 2, 2022

        // You have both Add(Option) and AddOption(Option).  Pick a paradigm.  I recommend "AddOption", since you need "AddGlobalOption" as different.
        // Also applies to Argument and Command as only having AddArgument and AddCommand.
        public void Add(Option option);
        public void Add(Argument argument);
        public void Add(Command command);
        public void AddArgument(Argument argument);
        public void AddCommand(Command command);
@jonsequitur jonsequitur mentioned this issue Nov 2, 2022
56 tasks
@adamsitnik adamsitnik self-assigned this Nov 4, 2022
@jonsequitur jonsequitur added this to the 2.0 GA milestone Nov 9, 2022
@KalleOlaviNiemitalo
Copy link

This was done in #1989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants