Skip to content

Move appropriate CommandLineBuilder methods to properties on CommandLineConfiguration #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1891
jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #2107
Closed
Tracked by #1891
Assignees
Labels
Milestone

Comments

@jonsequitur
Copy link
Contributor

jonsequitur commented Nov 2, 2022

        // Technically "cancel" is a verb, but I feel like the method is actually implying "Set" as the main verb and CancelOnProcessTermination is what the property would be called.
        // So, consider making this a property instead of a method when moving it.
        public static CommandLineBuilder CancelOnProcessTermination(this CommandLineBuilder builder);
        // These Enables also look like properties.
        public static CommandLineBuilder EnableDirectives(this CommandLineBuilder builder, bool value = True);
        public static CommandLineBuilder EnableLegacyDoubleDashBehavior(this CommandLineBuilder builder, bool value = True);
        public static CommandLineBuilder EnablePosixBundling(this CommandLineBuilder builder, bool value = True);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants