Skip to content

Consider differentiating these two *CompletionContext scenarios using fewer public types #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1891
jonsequitur opened this issue Nov 2, 2022 · 0 comments · Fixed by #2126
Closed
Tracked by #1891
Assignees
Labels
Area-API Area-Completions Related to support for tab completion
Milestone

Comments

@jonsequitur
Copy link
Contributor

jonsequitur commented Nov 2, 2022

    public class TextCompletionContext : CompletionContext 
    {
        public string CommandLineText { get; }
        public int CursorPosition { get; }
        public TextCompletionContext AtCursorPosition(int position);
    }
 
    // Does this class need to be public?  (Could some other library instantiate one meaningfully?)
    public class TokenCompletionContext : CompletionContext 
    {
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-API Area-Completions Related to support for tab completion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants