Skip to content

Doesn't work with Zip64 files #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EbrahimMajdey opened this issue Aug 16, 2018 — with docs.microsoft.com · 5 comments
Closed

Doesn't work with Zip64 files #834

EbrahimMajdey opened this issue Aug 16, 2018 — with docs.microsoft.com · 5 comments
Labels
area-System.IO.Compression doc-enhancement Improve the current content dotnet-api/prod Pri1 Indicates issues/PRs that are high priority
Milestone

Comments

Copy link

The ZipArchive can't read any entry that is larger than 4,294,967,295 bytes .. which is the old limit for zip files although the OS can read this.. would appreciate if such capabilities is enabled instead of using other packages


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@svick
Copy link
Contributor

svick commented Aug 16, 2018

First, this repo is for feedback on the documentation, so I think this issue doesn't belong here, unless you think this is something that should be pointed out in the documentation.

Second, as far as I can tell from https://github.com/dotnet/corefx/issues/9925, .Net Core does support Zip64 files. .Net Core improvements are sometimes ported to .Net Framework, though I'm not sure how likely is that in this case. Though it might still make sense to ask.

If you still want to provide feedback on .Net Framework, the right place is Developer Community. For .Net Core APIs, the right place is the corefx repo (but I don't think this is a .Net Core issue).

@mairaw
Copy link
Contributor

mairaw commented Aug 29, 2018

@ianhays can you help with this question? Is there something we should add to the docs? Thanks!

@EbrahimMajdey
Copy link
Author

Yes it should state in the documentation that it doesn't support Zip64, Nowadays it is common to find such large files, would be helpful also if it stays what future frameworks (if any) would support Zip64 .. It is not simple to switch from regular .Net to .Net core in exiting products

@ianhays
Copy link

ianhays commented Sep 27, 2018

@svick is correct.

There is also a distinction between zip64 and deflate64 and neither of them are exclusive with size limitations:

  • Zip64 is a modification of a zip itself and is supported on netcore and netfx.
  • Deflate64 is a separate compression algorithm used by some compressors to attempt to more efficiently encode zip entries that are greater than 4gb. Note that I said "entries", not zips. So a 5gb zip with 100 entries usually won't have Deflate64 entries. Again though, this is entirely up to the encoder. The most common source of deflate64-encoded entries in a zip is the Windows explorer zipper.
  • Both netfx and netcoreapp support zips larger than 4gb when they're encoded in supported methods and decoded in Read Mode.

Since we do support entries larger than 4gb, we shouldn't make any doc changes. We should probably backport Deflate64 support as a functional improvement, but that's a separate issue that should be filed elsewhere as @svick mentioned.

@BillWagner BillWagner transferred this issue from dotnet/docs Nov 20, 2018
@dotnet-bot dotnet-bot added untriaged New issue has not been triaged by the area owner Source - Docs.ms and removed rerun-labels labels Nov 20, 2018
@mairaw mairaw added Pri1 Indicates issues/PRs that are high priority and removed untriaged New issue has not been triaged by the area owner labels Nov 26, 2018
@mairaw mairaw added this to the Backlog milestone Nov 26, 2018
@mairaw mairaw added the doc-enhancement Improve the current content label Nov 26, 2018
@carlossanlop
Copy link
Member

I think this was answered a long time ago, so we should close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.IO.Compression doc-enhancement Improve the current content dotnet-api/prod Pri1 Indicates issues/PRs that are high priority
Projects
None yet
Development

No branches or pull requests

9 participants