Skip to content

Commit c102f43

Browse files
committed
Revert some unintended changes.
1 parent 3a24821 commit c102f43

File tree

4 files changed

+26
-44
lines changed

4 files changed

+26
-44
lines changed

tools/generator/CodeGenerationOptions.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,9 @@ public string GetNullForgiveness (Parameter symbol)
132132
return string.Empty;
133133
}
134134

135-
string GetNullable(string s)
135+
string GetNullable (string s)
136136
{
137-
switch (s)
138-
{
137+
switch (s) {
139138
case "void":
140139
case "int":
141140
//case "int[]":
@@ -162,7 +161,9 @@ string GetNullable(string s)
162161

163162
// Encoding format:
164163
// - Type name prefix: _JniMarshal_PP
165-
// - Parameter types, using JNI encoding, e.g. Z is boolean, I is int, etc. Exception: Reference types, normally encoded as L…;, are instead just L.
164+
// - Parameter types, using JNI encoding, e.g. Z is boolean, I is int, etc.
165+
// - Exception: Reference types, normally encoded as L…;, are instead just L.
166+
// - Lowercase JNI encoding indicates unsigned type, e.g. i is uint.
166167
// - Another _.
167168
// - Return type, encoded as with parameters. A void return type is V.
168169
internal string GetJniMarshalDelegate (Method method)

tools/generator/generator.csproj

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net472</TargetFramework>
4+
<TargetFrameworks>net472;netcoreapp3.1</TargetFrameworks>
55
<OutputType>Exe</OutputType>
66
<DefineConstants>$(DefineConstants);GENERATOR;HAVE_CECIL;JCW_ONLY_TYPE_NAMES</DefineConstants>
7-
<LangVersion>8.0</LangVersion>
87
</PropertyGroup>
98

109
<PropertyGroup>
1110
<OutputPath>$(UtilityOutputFullPath)</OutputPath>
1211
</PropertyGroup>
1312

13+
<ItemGroup>
14+
<None Remove="generator.slnf" />
15+
</ItemGroup>
16+
1417
<ItemGroup>
1518
<Compile Include="..\..\src\utils\StringRocks.cs">
1619
<Link>utils\StringRocks.cs</Link>
@@ -36,7 +39,6 @@
3639
</ItemGroup>
3740

3841
<ItemGroup>
39-
<ProjectReference Include="..\..\src\Xamarin.SourceWriter\Xamarin.SourceWriter.csproj" />
4042
<ProjectReference Include="..\..\src\Xamarin.Android.Tools.AnnotationSupport\Xamarin.Android.Tools.AnnotationSupport.csproj" />
4143
<ProjectReference Include="..\..\src\Xamarin.Android.Tools.ApiXmlAdjuster\Xamarin.Android.Tools.ApiXmlAdjuster.csproj" />
4244
<ProjectReference Include="..\..\src\Java.Interop.Tools.Diagnostics\Java.Interop.Tools.Diagnostics.csproj" />

tools/generator/generator.sln

Lines changed: 0 additions & 36 deletions
This file was deleted.

tools/generator/generator.slnf

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"solution": {
3+
"path": "C:\\code\\xamarin-android-backport\\external\\Java.Interop\\Java.Interop.sln",
4+
"projects": [
5+
"src\\Java.Interop.NamingCustomAttributes\\Java.Interop.NamingCustomAttributes.shproj",
6+
"src\\Java.Interop.Tools.Cecil\\Java.Interop.Tools.Cecil.csproj",
7+
"src\\Java.Interop.Tools.JavaCallableWrappers\\Java.Interop.Tools.JavaCallableWrappers.csproj",
8+
"src\\Java.Interop.Tools.Diagnostics\\Java.Interop.Tools.Diagnostics.csproj",
9+
"src\\Xamarin.Android.Tools.AnnotationSupport\\Xamarin.Android.Tools.AnnotationSupport.csproj",
10+
"src\\Xamarin.Android.Tools.ApiXmlAdjuster\\Xamarin.Android.Tools.ApiXmlAdjuster.csproj",
11+
"tests\\generator-Tests\\generator-Tests.csproj",
12+
"tools\\generator\\generator.csproj",
13+
]
14+
}
15+
}

0 commit comments

Comments
 (0)