Skip to content

Commit 53c1850

Browse files
committed
Address comments
1 parent 463b3e0 commit 53c1850

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/Microsoft.ML.Data/DataLoadSave/Text/TextLoader.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -978,7 +978,9 @@ private bool HasHeader
978978
/// <param name="dataSample">Allows to expose items that can be used for reading.</param>
979979
/// <param name="allowSparse">Whether the file can contain numerical vectors in sparse format.</param>
980980
/// <param name="allowQuoting">Whether the file can contain numerical vectors in sparse format.</param>
981-
public TextLoader(IHostEnvironment env, Column[] columns, bool hasHeader = false, char separatorChar = '\t', IMultiStreamSource dataSample = null, bool allowSparse = false, bool allowQuoting = false)
981+
public TextLoader(IHostEnvironment env, Column[] columns, bool hasHeader = DefaultArguments.HasHeader,
982+
char separatorChar = DefaultArguments.Separator, IMultiStreamSource dataSample = null,
983+
bool allowSparse = DefaultArguments.AllowSparse, bool allowQuoting = DefaultArguments.AllowQuoting)
982984
: this(env, MakeArgs(columns, hasHeader, new[] { separatorChar }, allowSparse, allowQuoting), dataSample)
983985
{
984986
}

src/Microsoft.ML.Data/DataLoadSave/Text/TextSaver.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ internal sealed class TextSaver : IDataSaver
2424
{
2525
internal static class DefaultArguments
2626
{
27-
internal const char Separator = '\t';
27+
internal const string Separator = "tab";
2828
internal const bool ForceDense = false;
2929
internal const bool OutputSchema = true;
3030
internal const bool OutputHeader = true;
@@ -34,7 +34,7 @@ internal static class DefaultArguments
3434
public sealed class Arguments
3535
{
3636
[Argument(ArgumentType.AtMostOnce, HelpText = "Separator", ShortName = "sep")]
37-
public string Separator = DefaultArguments.Separator.ToString();
37+
public string Separator = DefaultArguments.Separator;
3838

3939
[Argument(ArgumentType.AtMostOnce, HelpText = "Force dense format", ShortName = "dense")]
4040
public bool Dense = DefaultArguments.ForceDense;

0 commit comments

Comments
 (0)