Skip to content

Commit 69db84c

Browse files
committed
comment fixes
1 parent 4c40527 commit 69db84c

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/Microsoft.ML.StandardTrainers/StandardTrainersCatalog.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,8 @@ private static ICalibratorTrainer GetCalibratorTrainerOrThrow(IExceptionContext
725725

726726
/// <summary>
727727
/// Create a <see cref="OneVersusAllTrainer"/>, which predicts a multiclass target using one-versus-all strategy with
728-
/// the binary classification estimator specified by <paramref name="binaryEstimator"/>.
728+
/// the binary classification estimator specified by <paramref name="binaryEstimator"/>. If you want to retrieve strongly typed model parameters,
729+
/// use either the <see cref="OneVersusAllUnCalibratedToCalibrated{TModelIn, TCalibrator}"/> or <see cref="OneVersusAllTyped{TModel}"/> methods instead.
729730
/// </summary>
730731
/// <remarks>
731732
/// <para>
@@ -768,7 +769,8 @@ public static OneVersusAllTrainer OneVersusAll<TModel>(this MulticlassClassifica
768769
/// Create a <see cref="OneVersusAllTrainer{TModelOut}"/>, which predicts a multiclass target using one-versus-all strategy with
769770
/// the binary classification estimator specified by <paramref name="binaryEstimator"/>. This method works with binary classifiers that
770771
/// are either already calibrated, or non calibrated ones you don't want calibrated. If you need to have your classifier calibrated, use the
771-
/// <see cref="OneVersusAllUnCalibratedToCalibrated{TModelIn, TCalibrator}"/> method instead.
772+
/// <see cref="OneVersusAllUnCalibratedToCalibrated{TModelIn, TCalibrator}"/> method instead. If you want to retrieve strongly typed model parameters,
773+
/// you must use either this method or <see cref="OneVersusAllUnCalibratedToCalibrated{TModelIn, TCalibrator}"/> method.
772774
/// </summary>
773775
/// <remarks>
774776
/// <para>
@@ -808,7 +810,8 @@ public static OneVersusAllTrainer<TModel> OneVersusAllTyped<TModel>(this Multicl
808810
/// the binary classification estimator specified by <paramref name="binaryEstimator"/>.This method works with binary classifiers that
809811
/// are not calibrated and need to be calibrated before use. Due to the type of estimator changing (from uncalibrated to calibrated), you must manually
810812
/// specify both the type of the model and the type of the calibrator. If your classifier is already calibrated or it does not need to be, use the
811-
/// <see cref="OneVersusAllTyped{TModel}"/> method instead.
813+
/// <see cref="OneVersusAllTyped{TModel}"/> method instead. If you want to retrieve strongly typed model parameters, you must either use this method or
814+
/// <see cref="OneVersusAllTyped{TModel}"/> method.
812815
/// </summary>
813816
/// <remarks>
814817
/// <para>

test/Microsoft.ML.Tests/Scenarios/OvaTest.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ public void OvaLogisticRegression()
5353

5454
Assert.Equal(metrics.MicroAccuracy, metricsTyped.MicroAccuracy);
5555
}
56-
//.Append(ML.MulticlassClassification.Trainers.OneVersusAllUnCalibratedToCalibratedTyped<LinearBinaryModelParameters, PlattCalibrator>(sdcaTrainer))
5756

5857
[Fact]
5958
public void OvaAveragedPerceptron()

0 commit comments

Comments
 (0)