Skip to content

Commit 7e0cc46

Browse files
authored
Add loadable attribute for LinearMulticlassModelParameters (#3217)
1 parent 68640bb commit 7e0cc46

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

src/Microsoft.ML.StandardTrainers/Standard/LogisticRegression/MulticlassLogisticRegression.cs

+4
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@
3131
"Multiclass LR Executor",
3232
MaximumEntropyModelParameters.LoaderSignature)]
3333

34+
[assembly: LoadableClass(typeof(LinearMulticlassModelParameters), null, typeof(SignatureLoadModel),
35+
"Multiclass LR No Calib",
36+
LinearMulticlassModelParameters.LoaderSignature)]
37+
3438
[assembly: LoadableClass(typeof(void), typeof(LbfgsMaximumEntropyMulticlassTrainer), null, typeof(SignatureEntryPointModule), LbfgsMaximumEntropyMulticlassTrainer.LoadNameValue)]
3539

3640
namespace Microsoft.ML.Trainers

test/Microsoft.ML.Tests/TrainerEstimators/SdcaTests.cs

+5-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ public void SdcaWorkout()
1919

2020
var data = TextLoaderStatic.CreateLoader(Env, ctx => (Label: ctx.LoadFloat(0), Features: ctx.LoadFloat(1, 10)))
2121
.Load(dataPath).Cache();
22-
2322
var binaryData = ML.Transforms.Conversion.ConvertType("Label", outputKind: DataKind.Boolean)
2423
.Fit(data.AsDynamic).Transform(data.AsDynamic);
2524

@@ -36,11 +35,15 @@ public void SdcaWorkout()
3635

3736
TestEstimatorCore(regressionTrainer, data.AsDynamic);
3837
var mcData = ML.Transforms.Conversion.MapValueToKey("Label").Fit(data.AsDynamic).Transform(data.AsDynamic);
39-
38+
4039
var mcTrainer = ML.MulticlassClassification.Trainers.SdcaMaximumEntropy(
4140
new SdcaMaximumEntropyMulticlassTrainer.Options { ConvergenceTolerance = 1e-2f, MaximumNumberOfIterations = 10 });
4241
TestEstimatorCore(mcTrainer, mcData);
4342

43+
var mcTrainerNonCalibrated = ML.MulticlassClassification.Trainers.SdcaNonCalibrated(
44+
new SdcaNonCalibratedMulticlassTrainer.Options { ConvergenceTolerance = 1e-2f, MaximumNumberOfIterations = 10 });
45+
TestEstimatorCore(mcTrainerNonCalibrated, mcData);
46+
4447
Done();
4548
}
4649

0 commit comments

Comments
 (0)