Skip to content

Commit af43f81

Browse files
committed
addressing most of eerhardt's comments
1 parent c758415 commit af43f81

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

Microsoft.ML.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.Benchmarks.Tes
125125
EndProject
126126
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "samples", "samples", "{DA452A53-2E94-4433-B08C-041EDEC729E6}"
127127
EndProject
128-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.ML.Samples.StaticPipe", "docs\samples\Microsoft.ML.Samples.StaticPipe\Microsoft.ML.Samples.StaticPipe.csproj", "{E96D2EF3-F5D2-4BEE-8D2B-32C32A6344D2}"
128+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ML.Samples.StaticPipe", "docs\samples\Microsoft.ML.Samples.StaticPipe\Microsoft.ML.Samples.StaticPipe.csproj", "{E96D2EF3-F5D2-4BEE-8D2B-32C32A6344D2}"
129129
EndProject
130130
Global
131131
GlobalSection(SolutionConfigurationPlatforms) = preSolution

docs/samples/Microsoft.ML.Samples.StaticPipe/DatasetCreator.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
using System;
1+
// Licensed to the .NET Foundation under one or more agreements.
2+
// The .NET Foundation licenses this file to you under the MIT license.
3+
// See the LICENSE file in the project root for more information.
4+
5+
using System;
26
using System.Collections.Generic;
37
using System.IO;
48
using System.Text;
@@ -10,8 +14,8 @@ public static class DatasetCreator
1014
public static (string trainPath, string testPath) CreateRegressionDataset()
1115
{
1216
// creating a small sample dataset, and writting it to file
13-
string trainDataPath = @"c:\temp\RegressionTrainDataset.txt";
14-
string testDataPath = @"c:\temp\RegressionTestDataset.txt";
17+
string trainDataPath = @"RegressionTrainDataset.txt";
18+
string testDataPath = @"RegressionTestDataset.txt";
1519

1620
string header = "feature_a, feature_b, target";
1721

docs/samples/Microsoft.ML.Samples.StaticPipe/Microsoft.ML.Samples.StaticPipe.csproj

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,14 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>netcoreapp2.0</TargetFramework>
4+
<TargetFramework>netcoreapp2.1</TargetFramework>
55
<OutputType>Exe</OutputType>
6-
<StartupObject>Microsoft.ML.Samples.StaticPipe.Trainers</StartupObject>
76
</PropertyGroup>
87

98
<ItemGroup>
10-
<ProjectReference Include="..\..\..\src\Microsoft.ML.Data\Microsoft.ML.Data.csproj" />
11-
<ProjectReference Include="..\..\..\src\Microsoft.ML.ImageAnalytics\Microsoft.ML.ImageAnalytics.csproj" />
12-
<ProjectReference Include="..\..\..\src\Microsoft.ML.LightGBM\Microsoft.ML.LightGBM.csproj" />
139
<ProjectReference Include="..\..\..\src\Microsoft.ML.StandardLearners\Microsoft.ML.StandardLearners.csproj" />
14-
<ProjectReference Include="..\..\..\src\Microsoft.ML.PCA\Microsoft.ML.PCA.csproj" />
15-
16-
<NativeAssemblyReference Include="FastTreeNative" />
10+
1711
<NativeAssemblyReference Include="CpuMathNative" />
18-
<NativeAssemblyReference Include="FactorizationMachineNative" />
19-
<NativeAssemblyReference Include="LdaNative" />
2012

2113
<ProjectReference Include="..\..\..\src\Microsoft.ML.Analyzer\Microsoft.ML.Analyzer.csproj">
2214
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>

0 commit comments

Comments
 (0)