Skip to content

Commit d72c344

Browse files
committed
taking care of review comments
1 parent 5d6a2f6 commit d72c344

File tree

5 files changed

+5
-6
lines changed

5 files changed

+5
-6
lines changed

src/Microsoft.ML.Transforms/Text/TextFeaturizingEstimator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public sealed class Options : TransformInputBase
111111
[Argument(ArgumentType.AtMostOnce, HelpText = "Whether to keep numbers or remove them.", ShortName = "num", SortOrder = 8)]
112112
public bool KeepNumbers = TextNormalizingEstimator.Defaults.KeepNumbers;
113113

114-
[Argument(ArgumentType.AtMostOnce, HelpText = "Column containing the transformed text tokens.", ShortName = "OutputTokens,tokens,showtext,showTransformedText", SortOrder = 9)]
114+
[Argument(ArgumentType.AtMostOnce, HelpText = "Column containing the transformed text tokens.", ShortName = "tokens,showtext,showTransformedText", SortOrder = 9)]
115115
public string OutputTokensColumnName;
116116

117117
[Argument(ArgumentType.Multiple, HelpText = "A dictionary of whitelisted terms.", ShortName = "dict", NullName = "<None>", SortOrder = 10, Hide = true)]

test/BaselineOutput/Common/EntryPoints/core_manifest.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22440,7 +22440,6 @@
2244022440
"Type": "String",
2244122441
"Desc": "Column containing the transformed text tokens.",
2244222442
"Aliases": [
22443-
"OutputTokens",
2244422443
"tokens",
2244522444
"showtext",
2244622445
"showTransformedText"

test/BaselineOutput/SingleDebug/Text/featurized.tsv

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

test/BaselineOutput/SingleRelease/Text/featurized.tsv

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

test/Microsoft.ML.Tests/Transformers/TextFeaturizerTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public void TextFeaturizerWorkout()
4343
.AsDynamic;
4444

4545
var feat = data.MakeNewEstimator()
46-
.Append(row => row.text.FeaturizeText(options: new TextFeaturizingEstimator.Options { OutputTokensColumnName = "Data_TransformedText", }));
46+
.Append(row => row.text.FeaturizeText(options: new TextFeaturizingEstimator.Options { OutputTokensColumnName = "OutputTokens", }));
4747

4848
TestEstimatorCore(feat.AsDynamic, data.AsDynamic, invalidInput: invalidData);
4949

@@ -52,7 +52,7 @@ public void TextFeaturizerWorkout()
5252
{
5353
var saver = new TextSaver(ML, new TextSaver.Arguments { Silent = true });
5454
var savedData = ML.Data.TakeRows(feat.Fit(data).Transform(data).AsDynamic, 4);
55-
savedData = ML.Transforms.SelectColumns("Data", "Data_TransformedText").Fit(savedData).Transform(savedData);
55+
savedData = ML.Transforms.SelectColumns("Data", "OutputTokens").Fit(savedData).Transform(savedData);
5656

5757
using (var fs = File.Create(outputPath))
5858
DataSaverUtils.SaveDataView(ch, saver, savedData, fs, keepHidden: true);

0 commit comments

Comments
 (0)