Skip to content

Commit d9e0b4d

Browse files
author
Tom Finley
committed
Ivan comments
1 parent 08c9001 commit d9e0b4d

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/Microsoft.ML.Data/Commands/TrainCommand.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,6 @@ public static bool AddNormalizerIfNeeded(IHostEnvironment env, IChannel ch, ITra
522522
}
523523
}
524524
ch.Info("Automatically adding a MinMax normalization transform, use 'norm=Warn' or 'norm=No' to turn this behavior off.");
525-
// REVIEW: This verbose constructor should be replaced with zeahmed's enhancements once #405 is committed.
526525
IDataView ApplyNormalizer(IHostEnvironment innerEnv, IDataView input)
527526
=> NormalizeTransform.Create(innerEnv, new NormalizeTransform.MinMaxArguments()
528527
{

src/Microsoft.ML.FastTree/FastTree.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,18 +1347,16 @@ private Dataset Construct(RoleMappedData examples, ref int numExamples, int maxB
13471347
data = new LabelConvertTransform(Host, convArgs, data);
13481348
}
13491349
// Convert the group column, if one exists.
1350-
var groupInfo = examples.Schema.Group;
1351-
if (groupInfo != null)
1350+
if (examples.Schema.Group != null)
13521351
{
13531352
var convArgs = new ConvertTransform.Arguments();
13541353
var convCol = new ConvertTransform.Column
13551354
{
13561355
ResultType = DataKind.U8
13571356
};
1358-
convCol.Name = convCol.Source = groupInfo.Name;
1357+
convCol.Name = convCol.Source = examples.Schema.Group.Name;
13591358
convArgs.Column = new ConvertTransform.Column[] { convCol };
13601359
data = new ConvertTransform(Host, convArgs, data);
1361-
groupInfo = ColumnInfo.CreateFromName(data.Schema, convCol.Name, "converted group id");
13621360
}
13631361

13641362
// Since we've passed it through a few transforms, reconstitute the mapping on the

0 commit comments

Comments
 (0)