Skip to content

Commit dda64f2

Browse files
author
Rogan Carr
committed
Fixing an issue with no validation and no progress.
1 parent 8719606 commit dda64f2

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/Microsoft.ML.FastTree/GamTrainer.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ private protected GamTrainerBase(IHostEnvironment env, TArgs args)
148148
Host.CheckParam(0 < args.MinDocuments, nameof(args.MinDocuments), "Must be positive.");
149149

150150
Args = args;
151-
Info = new TrainerInfo(normalization: false, calibration: NeedCalibration, caching: false);
151+
Info = new TrainerInfo(normalization: false, calibration: NeedCalibration, caching: false, supportValid: true);
152152
_gainConfidenceInSquaredStandardDeviations = Math.Pow(ProbabilityFunctions.Probit(1 - (1 - Args.GainConfidenceLevel) * 0.5), 2);
153153
_entropyCoefficient = Args.EntropyCoefficient * 1e-6;
154154

@@ -269,8 +269,9 @@ private void TrainMainEffectsModel(IChannel ch)
269269
_objectiveFunction = CreateObjectiveFunction();
270270
var sumWeights = HasWeights ? TrainSet.SampleWeights.Sum() : 0;
271271

272-
pch.SetHeader(new ProgressHeader("iterations"), e => e.SetProgress(0, 0, iterations));
273-
for (int iteration = 0; iteration < iterations; iteration++)
272+
int iteration = 0;
273+
pch.SetHeader(new ProgressHeader("iterations"), e => e.SetProgress(0, iteration, iterations));
274+
for (int i = iteration; iteration < iterations; iteration++)
274275
{
275276
using (Timer.Time(TimerEvent.Iteration))
276277
{

0 commit comments

Comments
 (0)