Skip to content

Microsoft.ML.TensorFlow is currently broken #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eerhardt opened this issue Sep 25, 2018 · 5 comments
Closed

Microsoft.ML.TensorFlow is currently broken #1027

eerhardt opened this issue Sep 25, 2018 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@eerhardt
Copy link
Member

System information

  • OS version/distro: all
  • .NET Version (eg., dotnet --info): any

Issue

  • What did you do?
    Create a .NET Core console project that references the latest version of Microsoft.ML.TensorFlow.

  • What happened?
    I don't get a reference to the Microsoft.ML.TensorFlow.dll. I only get a reference to DnnAnalyzer.dll
    image

  • What did you expect?
    I expected to get a reference to Microsoft.ML.TensorFlow.dll so I could call methods in it.

Notes

The reason this happens is because we are including the DnnAnalyzer.dll in the lib\netcoreapp2.0 directory of the Microsoft.ML.TensorFlow nuget package:

image

NuGet only picks assets from 1 of these folders. And since my app is .NET Core, it only picks the assemblies from the lib\netcoreapp2.0 directory.

/cc @ericstj @yaeldekel @abgoswam

@ericstj
Copy link
Member

ericstj commented Sep 25, 2018

We shouldn't be putting DnnAnalyzer in the lib folder at the least. Perhaps we should consider a better place for tooling to get this info. Does ML.NET have any other command-line tools? Have we considered a CLI extension?

@shauheen shauheen added the bug Something isn't working label Sep 25, 2018
@shauheen shauheen added this to the 0918 milestone Sep 25, 2018
@eerhardt
Copy link
Member Author

We have the Maml.exe command line tool, which currently doesn't ship publicly. We've discussed making it a "global tool", but haven't executed on that plan.

@eerhardt
Copy link
Member Author

@TomFinley - I think you may have been mistaken. This isn’t the test break that just occurred. This is a problem with the assets in our NuGet packages. Specifically in the TensorFlow package.

@TomFinley
Copy link
Contributor

Whoops you're right sorry, got confused about the builds breaking.

@TomFinley
Copy link
Contributor

TomFinley commented Sep 25, 2018

Anyway, DnnAnalyzer should not be shipped in the nugets. It should have been rewritten as a command, but not in the nugets.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants