Skip to content

Tensorflow documentation issues #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ivanidzo4ka opened this issue Sep 26, 2018 · 2 comments · Fixed by #1077
Closed

Tensorflow documentation issues #1038

Ivanidzo4ka opened this issue Sep 26, 2018 · 2 comments · Fixed by #1077
Assignees

Comments

@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Sep 26, 2018

https://github.com/dotnet/machinelearning/blob/master/src/Microsoft.ML.TensorFlow/doc.xml

A) Look in example: var pipeline = new LearningPipeline(seed: 1); LearningPiepline actually don't have seed parameter

B) OutputColumns = "Output" OutputColumns is actually array, so you can't pass just string to it.

C) This transform requires the <a href="https://dotnet.myget.org/feed/dotnet-core/package/nuget/Microsoft.ML.TensorFlow/0.5.0-preview-26830-5">Microsoft.ML.TensorFlow</a> nuget to be installed.
I'm not sure we should include links to preview nuget package

D) The transform currently accepts the <a href="https://www.tensorflow.org/mobile/prepare_models">frozen TensorFlow model</a> file as input.
I think we support frozen and non frozen models.

@markusweimer
Copy link
Member

Good catch! Is there a way to automatically test these code examples such that we cannot make that mistake again?

@abgoswam
Copy link
Member

Issue #637 would enable the capability of automatically testing the code examples in our documentation

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants