Skip to content

Conversion: TryParseKey() throws an exception #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yaeldekel opened this issue Oct 8, 2018 · 0 comments · Fixed by #1236
Closed

Conversion: TryParseKey() throws an exception #1187

yaeldekel opened this issue Oct 8, 2018 · 0 comments · Fixed by #1236
Assignees
@yaeldekel
Milestone
1018

Comments

@yaeldekel
Copy link

The method checks that IsStdMissing() returns false, but it is called without doing that check.
We should remove this check and return false if IsStdMissing().
@yaeldekel yaeldekel self-assigned this Oct 8, 2018
@shauheen shauheen added this to the 1018 milestone Oct 9, 2018
@yaeldekel yaeldekel mentioned this issue Oct 12, 2018
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yaeldekel yaeldekel

Labels
None yet
Projects
None yet
Milestone
1018
2 participants
@shauheen @yaeldekel