Skip to content

FastTreeRanking doesn't have non-advanced args #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zruty0 opened this issue Oct 12, 2018 · 2 comments
Closed

FastTreeRanking doesn't have non-advanced args #1246

Zruty0 opened this issue Oct 12, 2018 · 2 comments
Assignees
Labels
bug Something isn't working up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@Zruty0
Copy link
Contributor

Zruty0 commented Oct 12, 2018

Consider the following constructors:

        public FastTreeBinaryClassificationTrainer(IHostEnvironment env,
            string labelColumn,
            string featureColumn,
            string weightColumn = null,
            int numLeaves = Defaults.NumLeaves,
            int numTrees = Defaults.NumTrees,
            int minDocumentsInLeafs = Defaults.MinDocumentsInLeafs,
            double learningRate = Defaults.LearningRates,
            Action<Arguments> advancedSettings = null)

        public FastTreeRegressionTrainer(IHostEnvironment env,
            string labelColumn,
            string featureColumn,
            string weightColumn = null,
            int numLeaves = Defaults.NumLeaves,
            int numTrees = Defaults.NumTrees,
            int minDocumentsInLeafs = Defaults.MinDocumentsInLeafs,
            double learningRate = Defaults.LearningRates,
            Action<Arguments> advancedSettings = null)

        public FastTreeRankingTrainer(IHostEnvironment env, string labelColumn, string featureColumn, string groupIdColumn,
            string weightColumn = null, Action<Arguments> advancedSettings = null)

There is no reason to have disparity here: ranker should expose the same numLeaves, numTrees etc.

The only difference should be the presence of required groupId in the ranker constructor.

@Zruty0 Zruty0 added bug Something isn't working up-for-grabs A good issue to fix if you are trying to contribute to the project labels Oct 12, 2018
@feiyun0112
Copy link
Contributor

@Zruty0
PR #1352 has fixed this issue

@shmoradims
Copy link

Yes, already fixed by PR #1352.

@shmoradims shmoradims self-assigned this Nov 28, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Development

No branches or pull requests

3 participants