Skip to content

Improve constructor for TextLoader #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zruty0 opened this issue Oct 17, 2018 · 2 comments
Closed

Improve constructor for TextLoader #1288

Zruty0 opened this issue Oct 17, 2018 · 2 comments
Labels
enhancement New feature or request up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@Zruty0
Copy link
Contributor

Zruty0 commented Oct 17, 2018 •
edited
Loading

We currently have

public TextLoader(IHostEnvironment env, Column[] columns, Action<Arguments> advancedSettings, IMultiStreamSource dataSample = null)
public TextLoader(IHostEnvironment env, Arguments args, IMultiStreamSource dataSample = null)

We need to:

  1. Make the second constructor internal or private (it's used only by cmdline/dependency injection.
  2. Add 'separator chars' and 'has header' as non-advanced parameters

The first change will naturally trigger a lot of changes in the code that creates the TextLoader, this is by design.
@Zruty0 Zruty0 added enhancement New feature or request up-for-grabs A good issue to fix if you are trying to contribute to the project labels Oct 17, 2018
@Prsna23
Copy link

Prsna23 commented Oct 18, 2018

I would like to work on this issue.

@artidoro
Copy link
Contributor

Will close this issue as it was taken care of in #1784.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Prsna23 @artidoro @Zruty0